Skip to content

test(TestInferenceService): prevent negative embedding values #136806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 21, 2025
Merged

test(TestInferenceService): prevent negative embedding values #136806

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bbd999e
fix(test:ci): prevent negative embedding values
mromaios Oct 20, 2025
f25baa6
Merge branch 'main' into 133453_fix_negative_embedding_value
mromaios Oct 20, 2025
b103dd8
fix overflow
mromaios Oct 20, 2025
b0999f5
[CI] Auto commit changes from spotless
Oct 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...main/java/org/elasticsearch/xpack/inference/mock/TestSparseInferenceServiceExtension.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,7 @@ protected ServiceSettings getServiceSettingsFromMap(Map<String, Object> serviceS

private static float generateEmbedding(String input, int position) {
// Ensure non-negative and non-zero values for features
return Math.abs(input.hashCode()) + 1 + position;
return Integer.toUnsignedLong(input.hashCode()) + 1 + position;
}

public static class Configuration {
Expand Down