Skip to content

Conversation

@chrisparrinello
Copy link
Contributor

Add a new APM metric to measure the duration of the can-match phase at the coordinator:

  • es.search_response.took_durations.can_match.histogram

@elasticsearchmachine elasticsearchmachine added needs:triage Requires assignment of a team area label v9.3.0 labels Oct 20, 2025
@chrisparrinello chrisparrinello added >enhancement Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch :Search Foundations/Search Catch all for Search Foundations and removed needs:triage Requires assignment of a team area label labels Oct 20, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search-foundations (Team:Search Foundations)

@elasticsearchmachine
Copy link
Collaborator

Hi @chrisparrinello, I've created a changelog YAML for you.

@chrisparrinello chrisparrinello requested review from a team as code owners October 24, 2025 17:39
@github-actions
Copy link
Contributor

ℹ️ Important: Docs version tagging

👋 Thanks for updating the docs! Just a friendly reminder that our docs are now cumulative. This means all 9.x versions are documented on the same page and published off of the main branch, instead of creating separate pages for each minor version.

We use applies_to tags to mark version-specific features and changes.

Expand for a quick overview

When to use applies_to tags:

✅ At the page level to indicate which products/deployments the content applies to (mandatory)
✅ When features change state (e.g. preview, ga) in a specific version
✅ When availability differs across deployments and environments

What NOT to do:

❌ Don't remove or replace information that applies to an older version
❌ Don't add new information that applies to a specific version without an applies_to tag
❌ Don't forget that applies_to tags can be used at the page, section, and inline level

🤔 Need help?

@chrisparrinello chrisparrinello force-pushed the can_match_phase_coordinator_metric branch from d9e923a to 3fd1850 Compare October 24, 2025 17:44
@chrisparrinello chrisparrinello force-pushed the can_match_phase_coordinator_metric branch from 3fd1850 to 76844ec Compare October 27, 2025 14:30
@mosche mosche removed the request for review from a team October 28, 2025 09:41
@javanna javanna removed request for a team October 29, 2025 08:52
Copy link
Member

@javanna javanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a couple of nits on testing, LGTM otherwise


public void testPointInTimeWithPreFiltering() {
OpenPointInTimeRequest request = new OpenPointInTimeRequest(indexName).keepAlive(TimeValue.timeValueMinutes(10));
request.indexFilter(simpleQueryStringQuery("doc1"));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you use a more realistic index filter? For instance a date range query instead? I was also wondering if setting the index filter is required for this test to work.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed it to a more complicated test. For this test to have two runs of can-match, we need to make sure we have at least two shards remaining after the open PIT can match. We have to have and index filter on the open PIT for can-match to run during that operation.

@chrisparrinello chrisparrinello merged commit 4ae62d6 into elastic:main Oct 30, 2025
34 checks passed
@chrisparrinello chrisparrinello deleted the can_match_phase_coordinator_metric branch October 30, 2025 18:31
chrisparrinello added a commit to chrisparrinello/elasticsearch that referenced this pull request Nov 3, 2025
Add a new APM metric to measure the duration of the can-match phase at the coordinator:

es.search_response.took_durations.can_match.histogram
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

>enhancement :Search Foundations/Search Catch all for Search Foundations Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch v9.3.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants