-
Notifications
You must be signed in to change notification settings - Fork 25.7k
Remove early phase failure in batched #136889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
benchaplin
merged 16 commits into
elastic:main
from
benchaplin:fix_batched_phase_failure
Nov 5, 2025
Merged
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
234089c
Rework reduction failure to be successful transport response
benchaplin 76e325c
Merge branch 'main' into fix_batched_phase_failure
benchaplin bf76a65
Update docs/changelog/136889.yaml
benchaplin 7540aa9
Set up new transport version
benchaplin c48633c
[CI] Update transport version definitions
d9d0b7f
[CI] Update transport version definitions
657c31b
Ensure bwc
benchaplin 1803ab7
Regenerate transport version
benchaplin f93d906
Fix
benchaplin 2ef1d2c
Merge branch 'main' into fix_batched_phase_failure
benchaplin 181c286
Make sure to return in case of IOException, add comments
benchaplin b60d882
Merge branch 'main' into fix_batched_phase_failure
benchaplin 961771c
Merge main
benchaplin e4f1f1c
Merge branch 'main' into fix_batched_phase_failure
benchaplin 7f5fa32
Remove assertion
benchaplin b89bf29
Merge branch 'main' into fix_batched_phase_failure
benchaplin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 change: 1 addition & 0 deletions
1
...rces/transport/definitions/referable/batched_response_might_include_reduction_failure.csv
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| 9198000 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| dimension_values,9197000 | ||
| batched_response_might_include_reduction_failure,9198000 |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.