-
Notifications
You must be signed in to change notification settings - Fork 25.7k
Use docvalue skippers on dimension fields #137029
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
elasticsearchmachine
merged 25 commits into
elastic:main
from
romseygeek:dimensions/sparse-indexes
Nov 13, 2025
Merged
Changes from 1 commit
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
a8d6c64
Default indexed to false for keyword dimension fields
romseygeek 1293cf4
[CI] Auto commit changes from spotless
553632c
Merge branch 'main' into dimensions/sparse-indexes
felixbarny 40bfeb3
Same for IpFieldMapper
romseygeek 0ca780c
Merge remote-tracking branch 'romseygeek/dimensions/sparse-indexes' i…
romseygeek 54f19a0
[CI] Auto commit changes from spotless
d059b5f
Merge branch 'main' into dimensions/sparse-indexes
felixbarny ccc5f32
Merge remote-tracking branch 'origin/main' into dimensions/sparse-ind…
romseygeek eae14b0
Merge remote-tracking branch 'origin/main' into dimensions/sparse-ind…
romseygeek 12cf479
wip
romseygeek eb86816
Use IndexType in TermBasedFieldType constructors
romseygeek e133d94
Merge branch 'kft/constructor-index-type' into dimensions/sparse-indexes
romseygeek 86e5275
Use sparse indexes for dimension fields
romseygeek c75fd0a
Merge remote-tracking branch 'origin/main' into dimensions/sparse-ind…
romseygeek 1a9b3a8
Merge remote-tracking branch 'origin/main' into dimensions/sparse-ind…
romseygeek ddd9647
iter
romseygeek b1c1ab7
Merge remote-tracking branch 'romseygeek/dimensions/sparse-indexes' i…
romseygeek ef2141a
Merge branch 'main' into dimensions/sparse-indexes
romseygeek 57b0a61
precommit
romseygeek b8e2e24
Merge remote-tracking branch 'romseygeek/dimensions/sparse-indexes' i…
romseygeek 667953e
iter
romseygeek 38ee47a
iter
romseygeek 59abb1d
Merge remote-tracking branch 'origin/main' into dimensions/sparse-ind…
romseygeek 1780fc5
Merge branch 'main' into dimensions/sparse-indexes
romseygeek cefc10e
Merge branch 'main' into dimensions/sparse-indexes
romseygeek File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this change will need to be applied to all field mappers that can be dimensions:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, and it will need gating behind a FeatureFlag and IndexVersion too. This is just for experimenting, really.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we at least also add
IpFieldMapper? I think that will be important for the experimentation.