Reject invalid reverse_nested aggs
#137047
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MattAlp
added
>bug
:Analytics/Aggregations
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
|
Hi @MattAlp, I've created a changelog YAML for you. |
MattAlp
commented
Oct 23, 2025
...t/java/org/elasticsearch/search/aggregations/bucket/nested/ReverseNestedAggregatorTests.java
Show resolved
Hide resolved
nik9000
approved these changes
Oct 24, 2025
There was a problem hiding this comment.
Looks good to me. @martijnvg should also look because he knows the nested stuff better than anyone.
| - match: { aggregations.courses.highpass_filter.unnest.department.buckets.1.doc_count: 1 } | ||
| --- | ||
| "Illegal reverse nested aggregation to a child nested object": | ||
| - do: |
There was a problem hiding this comment.
This'll also want a capability. Those live in SearchCapabilities. And, of course, it's not an enum.
martijnvg
approved these changes
Oct 27, 2025
💔 Backport failedThe backport operation could not be completed due to the following error: You can use sqren/backport to manually backport by running |
shmuelhanoch
pushed a commit
to shmuelhanoch/elasticsearch
that referenced
this pull request
Oct 29, 2025
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
MattAlp
added a commit
to MattAlp/elasticsearch
that referenced
this pull request
Oct 30, 2025
(cherry picked from commit b46f245)
MattAlp
added a commit
that referenced
this pull request
Oct 31, 2025
(cherry picked from commit b46f245)
MattAlp
added a commit
to MattAlp/elasticsearch
that referenced
this pull request
Oct 31, 2025
(cherry picked from commit b46f245)
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
chrisparrinello
pushed a commit
to chrisparrinello/elasticsearch
that referenced
this pull request
Nov 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #131232 by checking the path provided for a
reverse_nestedagg against the parent's aggregation path & throwing anIllegalArgumentExceptionif appropriate.