[ML] Fix MlAssignmentPlannerUpgradeIT.estMlAssignmentPlannerUpgrade() #137080
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in startDeployment method
valeriy42
added
>test
Collaborator
|
Pinging @elastic/ml-core (Team:ML) |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes MlAssignmentPlannerUpgradeIT.testMlAssignmentPlannerUpgrade() by changing model deployments from normal to low priority, allowing the test to succeed in single-processor environments where all processors are already allocated. The key changes enable low-priority deployments that don't require specific processor allocations.
- Removes the
@AwaitsFixannotation from the failing test - Updates
startDeploymentmethod overloads to support priority parameter - Changes deployment priority from "normal" to "low" for test models
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
prwhelan
approved these changes
Oct 24, 2025
valeriy42
added a commit
to valeriy42/elasticsearch
that referenced
this pull request
Oct 24, 2025
…elastic#137080) As suggested here, this PR changes deployments to low priority. Low priority deployments don't require specific processor allocations, allowing them to run in constrained environments. The test can now succeed in single-processor test environments where all processors are already allocated. Since we don't test BWC for pre-8.6.0 versions, where priority was introduced, this change fixes the test.
valeriy42
added a commit
to valeriy42/elasticsearch
that referenced
this pull request
Oct 24, 2025
…elastic#137080) As suggested here, this PR changes deployments to low priority. Low priority deployments don't require specific processor allocations, allowing them to run in constrained environments. The test can now succeed in single-processor test environments where all processors are already allocated. Since we don't test BWC for pre-8.6.0 versions, where priority was introduced, this change fixes the test.
Collaborator
fzowl
pushed a commit
to voyage-ai/elasticsearch
that referenced
this pull request
Nov 3, 2025
…elastic#137080) As suggested here, this PR changes deployments to low priority. Low priority deployments don't require specific processor allocations, allowing them to run in constrained environments. The test can now succeed in single-processor test environments where all processors are already allocated. Since we don't test BWC for pre-8.6.0 versions, where priority was introduced, this change fixes the test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested here, this PR changes deployments to low priority. Low priority deployments don't require specific processor allocations, allowing them to run in constrained environments. The test can now succeed in single-processor test environments where all processors are already allocated.
Since we don't test BWC for pre-8.6.0 versions, where priority was introduced, this change fixes the test.
Closes #101926