Skip to content

ESQL: Add a bit of javadoc to preanalysis methods #137099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alex-spies merged 3 commits into from
Oct 27, 2025
Merged

ESQL: Add a bit of javadoc to preanalysis methods #137099

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
960f99f
Add a bit of javadoc
alex-spies Oct 24, 2025
b92624d
[CI] Auto commit changes from spotless
Oct 24, 2025
fcd4c4b
Merge branch 'main' into describe-preanalysis-method
alex-spies Oct 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/session/EsqlSession.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -550,9 +550,9 @@ private void resolveIndicesAndAnalyze(
executionInfo
);

// The main index pattern dictates on which nodes the query can be executed, so we use the minimum transport version from this field
// caps request.
SubscribableListener.<PreAnalysisResult>newForked(
// The main index pattern dictates on which nodes the query can be executed, so we use the minimum transport version from this field
// caps request.
l -> preAnalyzeMainIndices(preAnalysis.indexes().entrySet().iterator(), preAnalysis, executionInfo, result, requestFilter, l)
).andThenApply(r -> {
if (r.indexResolution.isEmpty() == false // Rule out ROW case with no FROM clauses
Expand All @@ -576,6 +576,9 @@ private void resolveIndicesAndAnalyze(
.addListener(logicalPlanListener);
}

/**
* Perform a field caps request for each lookup index. Does not update the minimum transport version.
*/
private void preAnalyzeLookupIndices(
Iterator<IndexPattern> lookupIndices,
PreAnalysisResult preAnalysisResult,
Expand Down Expand Up @@ -795,6 +798,10 @@ private void validateRemoteVersions(EsqlExecutionInfo executionInfo) {
});
}

/**
* Perform a field caps request for each index pattern and determine the minimum transport version of all clusters with matching
* indices.
*/
private void preAnalyzeMainIndices(
Iterator<Map.Entry<IndexPattern, IndexMode>> indexPatterns,
PreAnalyzer.PreAnalysis preAnalysis,
Expand Down