Skip to content

[9.2] Remove auto_expand_replicas setting during index clone in searchable_snapshot (#137111) #137120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
elasticsearchmachine merged 1 commit into from
Oct 24, 2025
Merged

[9.2] Remove auto_expand_replicas setting during index clone in searchable_snapshot (#137111) #137120

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions docs/changelog/137111.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
pr: 137111
summary: Remove `auto_expand_replicas` setting during index clone in `searchable_snapshot`
area: ILM+SLM
type: bug
issues: []
6 changes: 5 additions & 1 deletion .../plugin/core/src/main/java/org/elasticsearch/xpack/core/ilm/SearchableSnapshotAction.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,11 @@ public class SearchableSnapshotAction implements LifecycleAction {
indexName,
state) -> state.forceMergeCloneIndexName() != null ? state.forceMergeCloneIndexName() : indexName;

private static final Settings CLONE_SETTINGS = Settings.builder().put(IndexMetadata.SETTING_NUMBER_OF_REPLICAS, 0).build();
/** The cloned index should have 0 replicas, so we also need to remove the auto_expand_replicas setting if present. */
private static final Settings CLONE_SETTINGS = Settings.builder()
.put(IndexMetadata.SETTING_NUMBER_OF_REPLICAS, 0)
.put(IndexMetadata.SETTING_AUTO_EXPAND_REPLICAS, (String) null)
.build();
private static final Function<IndexMetadata, Settings> CLONE_SETTINGS_SUPPLIER = indexMetadata -> CLONE_SETTINGS;

private static final ConstructingObjectParser<SearchableSnapshotAction, Void> PARSER = new ConstructingObjectParser<>(
Expand Down
8 changes: 7 additions & 1 deletion ...src/javaRestTest/java/org/elasticsearch/xpack/ilm/actions/SearchableSnapshotActionIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1033,11 +1033,17 @@ private String prepareDataStreamWithDocs(String phase, int numberOfPrimaries, in
createSnapshotRepo(client(), snapshotRepo, randomBoolean());
createNewSingletonPolicy(client(), policy, phase, new SearchableSnapshotAction(snapshotRepo, true));

final var indexSettings = indexSettings(numberOfPrimaries, numberOfReplicas);
// Randomly enable auto-expand replicas to test that we remove the setting for the clone with 0 replicas.
if (numberOfReplicas > 0 && randomBoolean()) {
logger.info("--> enabling auto-expand replicas on backing index");
indexSettings.put(IndexMetadata.SETTING_AUTO_EXPAND_REPLICAS, "1-all");
}
createComposableTemplate(
client(),
randomAlphaOfLengthBetween(5, 10).toLowerCase(Locale.ROOT),
dataStream,
new Template(indexSettings(numberOfPrimaries, numberOfReplicas).build(), null, null)
new Template(indexSettings.build(), null, null)
);
for (int i = 0; i < randomIntBetween(5, 10); i++) {
indexDocument(client(), dataStream, true);
Expand Down