Skip to content

[ML] Initialize backing indices before running integration test #137122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jonathan-buttner merged 6 commits into from
Oct 27, 2025
Merged

[ML] Initialize backing indices before running integration test #137122

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
efd7e05
Adding endpoint creation prior to tests
jonathan-buttner Oct 24, 2025
7cb5dc2
Moving to test that is failing
jonathan-buttner Oct 24, 2025
2ec40e8
Merge branch 'main' into ml-fix-default-it-tests
jonathan-buttner Oct 24, 2025
4127ec8
Deleting endpoint after creating it
jonathan-buttner Oct 24, 2025
5ccacc6
Merge branch 'ml-fix-default-it-tests' of github.com:jonathan-buttner…
jonathan-buttner Oct 24, 2025
ae2115c
Merge branch 'main' into ml-fix-default-it-tests
jonathan-buttner Oct 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions muted-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,9 +110,6 @@ tests:
issue: https://github.com/elastic/elasticsearch/issues/120339
- class: org.elasticsearch.xpack.sql.expression.function.scalar.datetime.DateTimeToCharProcessorTests
issue: https://github.com/elastic/elasticsearch/issues/120575
- class: org.elasticsearch.xpack.inference.DefaultEndPointsIT
method: testMultipleInferencesTriggeringDownloadAndDeploy
issue: https://github.com/elastic/elasticsearch/issues/120668
- class: org.elasticsearch.xpack.test.rest.XPackRestIT
method: test {p0=ml/3rd_party_deployment/Test start deployment fails while model download in progress}
issue: https://github.com/elastic/elasticsearch/issues/120810
Expand Down
10 changes: 7 additions & 3 deletions ...ice-tests/src/javaRestTest/java/org/elasticsearch/xpack/inference/DefaultEndPointsIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
import java.util.concurrent.CountDownLatch;

import static org.hamcrest.Matchers.empty;
import static org.hamcrest.Matchers.equalTo;
import static org.hamcrest.Matchers.greaterThanOrEqualTo;
import static org.hamcrest.Matchers.hasSize;
import static org.hamcrest.Matchers.is;
import static org.hamcrest.Matchers.oneOf;
Expand Down Expand Up @@ -75,7 +75,7 @@ public void testDefaultModels() throws IOException {

putModel("my-model", mockCompletionServiceModelConfig(TaskType.SPARSE_EMBEDDING, "streaming_completion_test_service"));
var registeredModels = getMinimalConfigs();
assertThat(registeredModels.size(), equalTo(1));
assertThat(registeredModels.size(), greaterThanOrEqualTo(1));
assertTrue(registeredModels.containsKey("my-model"));
assertFalse(registeredModels.containsKey(ElasticsearchInternalService.DEFAULT_E5_ID));
assertFalse(registeredModels.containsKey(ElasticsearchInternalService.DEFAULT_ELSER_ID));
Expand Down Expand Up @@ -194,7 +194,11 @@ private static void assertDefaultChunkingSettings(Map<String, Object> modelConfi
);
}

public void testMultipleInferencesTriggeringDownloadAndDeploy() throws InterruptedException {
public void testMultipleInferencesTriggeringDownloadAndDeploy() throws InterruptedException, IOException {
// Creating an inference endpoint to force the backing indices to be created to reduce the likelihood of the test failing
// because it's trying to interact with the indices while they're being created.
putModel("initial-model", mockCompletionServiceModelConfig(TaskType.SPARSE_EMBEDDING, "streaming_completion_test_service"));
Copy link
Contributor

@DonalEvans DonalEvans Oct 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you delete this endpoint right after creating it, will the backing indices still exist? If so, it would be cleaner to create then delete the endpoint so that you don't need to account for an extra endpoint hanging around in other tests.

Copy link
Contributor Author

@jonathan-buttner jonathan-buttner Oct 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I'll give that a shot 👍


int numParallelRequests = 4;
var latch = new CountDownLatch(numParallelRequests);
var errors = new ArrayList<Exception>();
Expand Down