Skip to content

Enable ReadAdvice in :qa:vector:checkVec utility #137180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iverase merged 1 commit into from
Oct 27, 2025
Merged

Enable ReadAdvice in :qa:vector:checkVec utility #137180

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions qa/vector/src/main/java/org/elasticsearch/test/knn/KnnIndexer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,10 +35,13 @@
import org.apache.lucene.index.VectorSimilarityFunction;
import org.apache.lucene.store.Directory;
import org.apache.lucene.store.FSDirectory;
import org.apache.lucene.store.IOContext;
import org.apache.lucene.store.MMapDirectory;
import org.apache.lucene.store.NativeFSLockFactory;
import org.apache.lucene.store.ReadAdvice;
import org.apache.lucene.util.PrintStreamInfoStream;
import org.elasticsearch.common.io.Channels;
import org.elasticsearch.index.StandardIOBehaviorHint;
import org.elasticsearch.index.store.FsDirectoryFactory;

import java.io.IOException;
Expand All @@ -51,12 +54,14 @@
import java.util.ArrayList;
import java.util.List;
import java.util.Objects;
import java.util.Optional;
import java.util.concurrent.ExecutionException;
import java.util.concurrent.ExecutorService;
import java.util.concurrent.Executors;
import java.util.concurrent.Future;
import java.util.concurrent.TimeUnit;
import java.util.concurrent.atomic.AtomicInteger;
import java.util.function.BiFunction;

import static org.elasticsearch.test.knn.KnnIndexTester.logger;

Expand Down Expand Up @@ -241,11 +246,21 @@ public boolean isEnabled(String component) {
static Directory getDirectory(Path indexPath) throws IOException {
Directory dir = FSDirectory.open(indexPath);
if (dir instanceof MMapDirectory mmapDir) {
mmapDir.setReadAdvice(getReadAdviceFunc()); // enable madvise
return new FsDirectoryFactory.HybridDirectory(NativeFSLockFactory.INSTANCE, mmapDir, 64);
}
return dir;
}

private static BiFunction<String, IOContext, Optional<ReadAdvice>> getReadAdviceFunc() {
return (name, context) -> {
if (context.hints().contains(StandardIOBehaviorHint.INSTANCE) || name.endsWith(".cfs")) {
return Optional.of(ReadAdvice.NORMAL);
}
return MMapDirectory.ADVISE_BY_CONTEXT.apply(name, context);
};
}

static class IndexerThread extends Thread {
private final IndexWriter iw;
private final AtomicInteger numDocsIndexed;
Expand Down