Add coerce setting to histogram field mapper #137191
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonasKunz
added
>non-issue
:StorageEngine/Mapping
elasticsearchmachine
added
external-contributor
Collaborator
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
2 tasks
felixbarny
approved these changes
Oct 28, 2025
...lytics/src/test/java/org/elasticsearch/xpack/analytics/mapper/HistogramFieldMapperTests.java
Outdated
Show resolved
Hide resolved
kkrik-es
reviewed
Oct 29, 2025
...ytics/src/main/java/org/elasticsearch/xpack/analytics/mapper/ExponentialHistogramParser.java
Outdated
Show resolved
Hide resolved
kkrik-es
reviewed
Oct 29, 2025
...alytics/src/main/java/org/elasticsearch/xpack/analytics/mapper/ParsedHistogramConverter.java
Show resolved
Hide resolved
kkrik-es
reviewed
Oct 29, 2025
| } catch (IOException e) { | ||
| throw new RuntimeException(e); | ||
| } | ||
| return new HistogramParser.ParsedHistogram(values, counts); |
Contributor
There was a problem hiding this comment.
So here you're cloning the implementation.. Maybe we should just verify that we get the numbers we're expecting, instead.
Contributor
There was a problem hiding this comment.
Or maybe check that some percentile values are close enough.
Contributor
Author
There was a problem hiding this comment.
You mean the fact that we delegate to ParsedHistogramConverter.exponentialToTDigest in the tests?
This is intentional. This unit test is not supposed to verify the correctness of the conversion algorithm, that is done by ParsedHistogramConverterTests. These keeps the tests small, while not loosing out on coverage
kkrik-es
approved these changes
Oct 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #136605.
Adds a
coerceparameter to the classichistogramfield mapper, which is for now hidden behind the exponential-histograms feature flag. Whencoerceis enabled (which it is by default),histogramfields will also acceptexponential_histogramJSON and convert it to T-Digests like we do in both the EDOT collector and in the elasticsearch OTLP-endpoint.The added tests are randomized, I've ran them locally with 10k iterations with no failures.