Skip to content

Conversation

@markjhoy
Copy link
Contributor

Two of the sparse_vector integration tests are sporadically failing due to extra results in the output. This PR attempts to fix that by ensuring those test indices are deleted and the index metadata is refreshed.

The two tests (in x-pack) are:

  • ml/sparse_vector_search/Check sparse_vector should prune by default
  • ml/sparse_vector_search/Test sparse_vector search with query vector and pruning config

Copy link
Member

@kderusso kderusso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realize that we can't repro this locally but we should probably unmute the tests if we think this is the fix.

@markjhoy
Copy link
Contributor Author

I realize that we can't repro this locally but we should probably unmute the tests if we think this is the fix.

Ah - good idea - where can this be found? I can't seem to find it :/

@kderusso
Copy link
Member

@markjhoy Muted tests are in muted-tests.yml - you can remove the 3 lines for each applicable muted test.

@markjhoy markjhoy added the :SearchOrg/Relevance Label for the Search (solution/org) Relevance team label Oct 27, 2025
@elasticsearchmachine elasticsearchmachine added Team:Search - Relevance The Search organization Search Relevance team and removed needs:triage Requires assignment of a team area label labels Oct 27, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/search-relevance (Team:Search - Relevance)

@markjhoy markjhoy merged commit 2d45a8d into elastic:main Oct 28, 2025
34 checks passed
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

Status Branch Result
9.2 Commit could not be cherrypicked due to conflicts
8.19 Commit could not be cherrypicked due to conflicts
9.1 Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 137202

markjhoy added a commit to markjhoy/elasticsearch that referenced this pull request Oct 28, 2025
* add indices to deletion on teardown

* unmute test (only the 1 is muted)

(cherry picked from commit 2d45a8d)

# Conflicts:
#	muted-tests.yml
markjhoy added a commit to markjhoy/elasticsearch that referenced this pull request Oct 28, 2025
* add indices to deletion on teardown

* unmute test (only the 1 is muted)

(cherry picked from commit 2d45a8d)

# Conflicts:
#	muted-tests.yml
markjhoy added a commit to markjhoy/elasticsearch that referenced this pull request Oct 28, 2025
* add indices to deletion on teardown

* unmute test (only the 1 is muted)

(cherry picked from commit 2d45a8d)

# Conflicts:
#	muted-tests.yml
@markjhoy
Copy link
Contributor Author

💚 All backports created successfully

Status Branch Result
9.2
9.1
8.19

Questions ?

Please refer to the Backport tool documentation

markjhoy added a commit that referenced this pull request Oct 28, 2025
* add indices to deletion on teardown

* unmute test (only the 1 is muted)

(cherry picked from commit 2d45a8d)

# Conflicts:
#	muted-tests.yml
markjhoy added a commit that referenced this pull request Oct 28, 2025
* add indices to deletion on teardown

* unmute test (only the 1 is muted)

(cherry picked from commit 2d45a8d)

# Conflicts:
#	muted-tests.yml
markjhoy added a commit that referenced this pull request Oct 28, 2025
* add indices to deletion on teardown

* unmute test (only the 1 is muted)

(cherry picked from commit 2d45a8d)

# Conflicts:
#	muted-tests.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Automatically create backport pull requests when merged backport pending >non-issue :SearchOrg/Relevance Label for the Search (solution/org) Relevance team Team:Search - Relevance The Search organization Search Relevance team >test Issues or PRs that are addressing/adding tests v8.19.7 v9.1.7 v9.2.1 v9.3.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants