-
Notifications
You must be signed in to change notification settings - Fork 25.7k
Fix flakiness on YAML tests for Sparse Vector #137202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix flakiness on YAML tests for Sparse Vector #137202
Conversation
kderusso
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I realize that we can't repro this locally but we should probably unmute the tests if we think this is the fix.
Ah - good idea - where can this be found? I can't seem to find it :/ |
|
@markjhoy Muted tests are in muted-tests.yml - you can remove the 3 lines for each applicable muted test. |
|
Pinging @elastic/search-relevance (Team:Search - Relevance) |
💔 Backport failed
You can use sqren/backport to manually backport by running |
* add indices to deletion on teardown * unmute test (only the 1 is muted) (cherry picked from commit 2d45a8d) # Conflicts: # muted-tests.yml
* add indices to deletion on teardown * unmute test (only the 1 is muted) (cherry picked from commit 2d45a8d) # Conflicts: # muted-tests.yml
* add indices to deletion on teardown * unmute test (only the 1 is muted) (cherry picked from commit 2d45a8d) # Conflicts: # muted-tests.yml
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
Two of the
sparse_vectorintegration tests are sporadically failing due to extra results in the output. This PR attempts to fix that by ensuring those test indices are deleted and the index metadata is refreshed.The two tests (in x-pack) are:
ml/sparse_vector_search/Check sparse_vector should prune by defaultml/sparse_vector_search/Test sparse_vector search with query vector and pruning config