[CI] Workaround for Windows packaging tests hang on uploading artifacts #137206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to check the theory that the process hangs because of the buffers fill up.
Calculate upload timeout based on file size. This change replaces the fixed 30-minute timeout with a calculated value, to avoid buildkite-agent on Windows hanging for 30 minutes for small files.
jozala
added
>non-issue
:Delivery/Build
elasticsearchmachine
added
v9.2.1
v8.19.7
v9.1.7
and removed
branch:9.2
branch:9.1
branch:8.19
labels
jozala
changed the title
|
Pinging @elastic/es-delivery (Team:Delivery) |
jozala
changed the title
|
Took 10 seconds instead of 30 minutes now: https://buildkite.com/elastic/elasticsearch-pull-request/builds/101027#019a29f8-08ac-4bcd-b167-1af92febb4c7/309-1781 |
neilbhavsar
reviewed
Oct 29, 2025
...ternal/src/main/java/org/elasticsearch/gradle/internal/ElasticsearchBuildCompletePlugin.java
Outdated
Show resolved
Hide resolved
neilbhavsar
reviewed
Oct 29, 2025
...ternal/src/main/java/org/elasticsearch/gradle/internal/ElasticsearchBuildCompletePlugin.java
Show resolved
Hide resolved
brianseeders
approved these changes
Oct 29, 2025
This was referenced Oct 31, 2025
Merged
jozala
added a commit
to jozala/elasticsearch
that referenced
this pull request
Oct 31, 2025
…ts (elastic#137206) Calculate upload timeout based on file size. This change replaces the fixed 30-minute timeout with a calculated value, to avoid buildkite-agent on Windows hanging for 30 minutes for small files. (cherry picked from commit c527bbf)
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
jozala
added a commit
to jozala/elasticsearch
that referenced
this pull request
Oct 31, 2025
…ts (elastic#137206) Calculate upload timeout based on file size. This change replaces the fixed 30-minute timeout with a calculated value, to avoid buildkite-agent on Windows hanging for 30 minutes for small files. (cherry picked from commit c527bbf)
jozala
added a commit
to jozala/elasticsearch
that referenced
this pull request
Oct 31, 2025
…ts (elastic#137206) Calculate upload timeout based on file size. This change replaces the fixed 30-minute timeout with a calculated value, to avoid buildkite-agent on Windows hanging for 30 minutes for small files. (cherry picked from commit c527bbf)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It calculates the with timeout based on the size of the file with the minimum set to 10 seconds and max set to 30 minutes. This should be more than enough and it doesn't change the maximum as the wait timeout was previously fixed to 30 minutes.
To make it clear - the wait timeout is the maximum time the process can run. If the process finish earlier than the given wait timeout, then this will not wait. The only exception is on Windows where for unknown reason this process has been hanged until the wait timeout. This workaround should minimize the time we wait in CI on Windows for this process to finish.
There is an issue for the buildkite agent related to this issue: buildkite/agent#3044.