Skip to content

Conversation

@jordan-powers
Copy link
Contributor

@jordan-powers jordan-powers commented Oct 28, 2025

With this PR, text fields will delegate synthetic_source storage to normalized keyword fields when the normalizer_skip_store_original_value parameter is set on the keyword field.

Follow-up to #136915.

Relates to #132962.

Relates to #124369.

Resolves #124369.

@jordan-powers jordan-powers self-assigned this Oct 28, 2025
@jordan-powers jordan-powers added >non-issue :StorageEngine/Mapping The storage related side of mappings labels Oct 28, 2025
@jordan-powers jordan-powers marked this pull request as ready for review October 28, 2025 16:07
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-storage-engine (Team:StorageEngine)

@jordan-powers jordan-powers requested a review from Kubik42 October 29, 2025 16:05
Copy link
Contributor

@Kubik42 Kubik42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Member

@martijnvg martijnvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM2!

With this change in, this would close #124369?

raw:
type: keyword
normalizer: lowercase
normalizer_skip_store_original_value: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe also add a yaml test where we don't set this mapping attribute? This should have the same outcome as this yaml test.

@jordan-powers jordan-powers enabled auto-merge (squash) October 31, 2025 01:07
@jordan-powers jordan-powers merged commit 09f5349 into elastic:main Oct 31, 2025
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enable native synthetic source for keyword fields with normalizers

4 participants