- 
                Notifications
    You must be signed in to change notification settings 
- Fork 25.6k
Delegate synthetic source to keyword multi-fields when skip_store_original_value #137229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delegate synthetic source to keyword multi-fields when skip_store_original_value #137229
Conversation
| Pinging @elastic/es-storage-engine (Team:StorageEngine) | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM2!
With this change in, this would close #124369?
| raw: | ||
| type: keyword | ||
| normalizer: lowercase | ||
| normalizer_skip_store_original_value: true | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe also add a yaml test where we don't set this mapping attribute? This should have the same outcome as this yaml test.
…re-original-text-multifield
With this PR, text fields will delegate synthetic_source storage to normalized keyword fields when the
normalizer_skip_store_original_valueparameter is set on the keyword field.Follow-up to #136915.
Relates to #132962.
Relates to #124369.
Resolves #124369.