Skip to content

WriteLoadConstraintDecider: Don't require shard write load to return canRemain=NOT_PREFERRED #137416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nicktindall merged 3 commits into from
Nov 1, 2025
Merged

WriteLoadConstraintDecider: Don't require shard write load to return canRemain=NOT_PREFERRED #137416

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
df0e5fb
Don't require shard write load to return canRemain=NOT_PREFERRED
nicktindall Oct 31, 2025
6fc953f
Add back test
nicktindall Oct 31, 2025
57d3878
Merge branch 'main' into dont_require_shard_write_load_canRemain
nicktindall Oct 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions ...java/org/elasticsearch/cluster/routing/allocation/decider/WriteLoadConstraintDecider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,13 +129,6 @@ public Decision canRemain(IndexMetadata indexMetadata, ShardRouting shardRouting
return Decision.single(Decision.Type.YES, NAME, "canRemain() is not enabled");
}

// Check whether the shard being relocated has any write load estimate. If it does not, then this decider has no opinion.
var allShardWriteLoads = allocation.clusterInfo().getShardWriteLoads();
var shardWriteLoad = allShardWriteLoads.get(shardRouting.shardId());
if (shardWriteLoad == null || shardWriteLoad == 0) {
return Decision.single(Decision.Type.YES, NAME, "Shard has no estimated write load. Decider takes no action.");
}

var allNodeUsageStats = allocation.clusterInfo().getNodeUsageStatsForThreadPools();
var nodeUsageStatsForThreadPools = allNodeUsageStats.get(node.nodeId());
if (nodeUsageStatsForThreadPools == null) {
Expand Down
10 changes: 0 additions & 10 deletions ...org/elasticsearch/cluster/routing/allocation/decider/WriteLoadConstraintDeciderTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,16 +233,6 @@ public void testWriteLoadDeciderCanRemain() {
testHarness.routingAllocation
).type()
);
assertEquals(
"A shard without write load should remain on a node with queuing above the threshold",
Decision.Type.YES,
writeLoadDecider.canRemain(
testHarness.clusterState.metadata().getProject().index(indexName),
testHarness.shardRoutingNoWriteLoad,
testHarness.aboveQueuingThresholdRoutingNode,
testHarness.routingAllocation
).type()
);
Comment on lines 236 to 245
Copy link
Member

@ywangd ywangd Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have a test to show a shard without write load can still trigger NOT_PREFERRED?

Copy link
Contributor Author

@nicktindall nicktindall Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will add one

Copy link
Contributor Author

@nicktindall nicktindall Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added in 6fc953f

}

private void assertDecisionMatches(String description, Decision decision, Decision.Type type, String explanationPattern) {
Expand Down