-
Notifications
You must be signed in to change notification settings - Fork 25.7k
TransportClusterSearchShardsAction runs locally #137453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TransportClusterSearchShardsAction runs locally #137453
Conversation
b3bfb79 to
eeb3f2e
Compare
|
I'm not sure what :team and area this PR belongs to. Any ideas? |
|
Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination) |
This action only need cluster state and can be run any node. Make sure to keep necessary serialization and deserialization for BwC.
ef4b8ac to
10effaf
Compare
DaveCTurner
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok the tests seem very unhappy because we use this request on remote clusters. The change to a LocalClusterStateRequest is still valid because we want the handling node in the remote cluster to respond directly rather than forwarding the response on to its own master node, but we will have to continue supporting sending this action over the wire.
We'll need to make a separate org.elasticsearch.action.RemoteClusterActionType to distinguish the cluster-local action from the one that works on remote clusters, and also find a way to distinguish the local request (which rejects writeTo() calls) from the request that gets sent to the remote cluster.
| private final IndexNameExpressionResolver indexNameExpressionResolver; | ||
|
|
||
| /** | ||
| * AP prior to 9.3 this was a {@link TransportMasterNodeReadAction} so for BwC it must be registered with the TransportService until |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need for the AP - we can use git annotate to find you if we need to :)
|
After offline discussion with @DaveCTurner I've concluded that this task is much too involved for a first PR and I will close it now. |
This action only need cluster state and can be run any node. Make sure to keep necessary serialization and deserialization for BwC.
Relates #101805