TransportGetBasicStatusAction runs on local #137567
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elasticsearchmachine
added
v9.3.0
needs:triage
burqen
added
the
:Distributed Coordination/Distributed
elasticsearchmachine
added
Team:Distributed Coordination
Collaborator
|
Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination) |
Collaborator
|
Hi @burqen, I've created a changelog YAML for you. |
It only relies on cluster state. Also, replace GetBasicStatusAction with inline instance of ActionType.
We need to register a request handler for TransportGetBasicStatusAction and make it possible for requests to be read from transport layer in order to support old versions sending GetBasicStatusRequest to us.
burqen
force-pushed
the
2025.11.04.TransportGetBasicStatusAction-run-on-local
branch
from
ca34860 to
1c6eda4
Compare
DaveCTurner
approved these changes
Nov 5, 2025
Contributor
DaveCTurner
left a comment
DaveCTurner
left a comment
There was a problem hiding this comment.
LGTM (optional comment)
|
|
||
| private static GetBasicStatusResponse getBasicStatus() { | ||
| return safeGet(clusterAdmin().execute(GetBasicStatusAction.INSTANCE, new GetBasicStatusRequest(TEST_REQUEST_TIMEOUT))); | ||
| return safeGet(clusterAdmin().execute(TransportGetBasicStatusAction.TYPE, new GetBasicStatusRequest(TEST_REQUEST_TIMEOUT))); |
Contributor
There was a problem hiding this comment.
This doesn't need to get the specialized cluster admin client:
Suggested change
| return safeGet(clusterAdmin().execute(TransportGetBasicStatusAction.TYPE, new GetBasicStatusRequest(TEST_REQUEST_TIMEOUT))); | |
| return safeGet(client().execute(TransportGetBasicStatusAction.TYPE, new GetBasicStatusRequest(TEST_REQUEST_TIMEOUT))); |
(not introduced in this PR, in fact it was my mistake in #109121, but may as well clean it up here now)
|
|
||
| private static PostStartBasicResponse startBasic(boolean acknowledged) { | ||
| return safeGet( | ||
| clusterAdmin().execute( |
45 tasks
afoucret
pushed a commit
to afoucret/elasticsearch
that referenced
this pull request
Nov 6, 2025
* TransportGetBasicStatusAction runs on local It only relies on cluster state. Also, replace GetBasicStatusAction with inline instance of ActionType. * Handle BwC in TransportGetBasicStatusAction We need to register a request handler for TransportGetBasicStatusAction and make it possible for requests to be read from transport layer in order to support old versions sending GetBasicStatusRequest to us. * Update docs/changelog/137567.yaml * Use client() instead of clusterAdmin() in test
Kubik42
pushed a commit
to Kubik42/elasticsearch
that referenced
this pull request
Nov 10, 2025
* TransportGetBasicStatusAction runs on local It only relies on cluster state. Also, replace GetBasicStatusAction with inline instance of ActionType. * Handle BwC in TransportGetBasicStatusAction We need to register a request handler for TransportGetBasicStatusAction and make it possible for requests to be read from transport layer in order to support old versions sending GetBasicStatusRequest to us. * Update docs/changelog/137567.yaml * Use client() instead of clusterAdmin() in test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It only relies on cluster state. Also, replace GetBasicStatusAction with inline instance of ActionType.
Relates to #101805