PIT context relocation work on main repo #137675
Open
+85
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbuescher
added
>enhancement
:Search Foundations/Search
Collaborator
|
Pinging @elastic/es-search-foundations (Team:Search Foundations) |
elasticsearchmachine
added
the
Team:Search Foundations
Collaborator
|
Hi @cbuescher, I've created a changelog YAML for you. |
elasticsearchmachine
added
the
serverless-linked
cbuescher
force-pushed
the
pit-relocation
branch
from
272b88b to
ebd6a0b
Compare
fcofdez
approved these changes
Nov 12, 2025
| import static org.elasticsearch.test.hamcrest.ElasticsearchAssertions.assertNoFailuresAndResponse; | ||
| import static org.hamcrest.Matchers.equalTo; | ||
|
|
||
| @TestIssueLogging( |
Member
Author
There was a problem hiding this comment.
Only here for improved visibility during testing, will remove before merge
This adds a kind of "dirty" flag to a ReaderContext that can be used to make it immediately elgible for cleanup when the reaper process runs. We cannot really achieve this using the current keepalive setting since keepalive will be restarted every time a context is used. In some PIT relocation scenarios we need to make a context "unusable" for new searches without immediately removing it for running searches (i.e. when we remove a context after a search has started, some phases like DFSQueryPhase don't retry on missing contexts, so those searches would fail if we immediately close the context).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work to support PIT context relocation when nodes gracefully shut down and shards are relocated.