Skip to content

Change DatabaseNodeService error logs to warnings #138438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+10 −5
Open

Change DatabaseNodeService error logs to warnings #138438

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8a7d27d
Change DatabaseNodeService error logs to warnings
masseyke Nov 21, 2025
49627d2
Update docs/changelog/138438.yaml
masseyke Nov 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions docs/changelog/138438.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
pr: 138438
Copy link
Contributor

@szybia szybia Nov 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we backport as well?

sounds like a nice-to-have

summary: Change `DatabaseNodeService` error logs to warnings
area: Ingest Node
type: bug
issues: []
10 changes: 5 additions & 5 deletions modules/ingest-geoip/src/main/java/org/elasticsearch/ingest/geoip/DatabaseNodeService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -371,7 +371,7 @@ void checkDatabases(ProjectState projectState) {
try {
retrieveAndUpdateDatabase(projectId, name, metadata);
} catch (Exception ex) {
logger.error(() -> "failed to retrieve database [" + name + "]", ex);
logger.warn(() -> "failed to retrieve database [" + name + "]", ex);
}
});

Expand Down Expand Up @@ -468,13 +468,13 @@ void retrieveAndUpdateDatabase(ProjectId projectId, String databaseName, GeoIpTa
Files.delete(retrievedFile);
},
failure -> {
logger.error(() -> "failed to retrieve database [" + databaseName + "]", failure);
logger.warn(() -> "failed to retrieve database [" + databaseName + "]", failure);
try {
Files.deleteIfExists(databaseTmpFile);
Files.deleteIfExists(retrievedFile);
} catch (IOException ioe) {
ioe.addSuppressed(failure);
logger.error("unable to delete tmp database file after failure", ioe);
logger.warn("unable to delete tmp database file after failure", ioe);
}
}
);
Expand Down Expand Up @@ -519,7 +519,7 @@ void updateDatabase(ProjectId projectId, String databaseFileName, String recorde
}
logger.info("successfully loaded database file [{}]", file.getFileName());
} catch (Exception e) {
logger.error(() -> "failed to update database [" + databaseFileName + "]", e);
logger.warn(() -> "failed to update database [" + databaseFileName + "]", e);
}
}

Expand All @@ -533,7 +533,7 @@ void removeStaleEntries(ProjectId projectId, Collection<String> staleEntries) {
assert existing != null;
existing.shutdown(true);
} catch (Exception e) {
logger.error(() -> "failed to clean database [" + staleEntry + "] for project [" + projectId + "]", e);
logger.warn(() -> "failed to clean database [" + staleEntry + "] for project [" + projectId + "]", e);
}
}
}
Expand Down