Enforce maximum ttl on async search requests #138442
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mark-vieira
added
>non-issue
:Core/Infra/Core
mark-vieira
changed the title
elasticsearchmachine
added
Team:Core/Infra
Collaborator
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
Collaborator
|
Pinging @elastic/es-search-foundations (Team:Search Foundations) |
Contributor
Author
|
I chose 30 days here pretty arbitrarily. I'm open to suggestions. Additionally, this could be considered a breaking change. Should we make this a soft limit by introducing a cluster setting here so folks can override? Perhaps immediately deprecating the setting so it can be removed in the next version? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Async search results are intended to be short lived. Currently, we don't enforce any maximum on
keep_alive. Very long TTLs can be problematic because async search results are not indefinitely supported. Eventually, due to transport versioning support changes, old results will no longer be readable. Since it doesn't make sense to keep this stuff for very long timeframes, we should restrict this to a reasonable duration.