Enable skippers for fields with index=false and doc_values=true #138523
+274
−46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This applies to boolean, date, ip, keyword and number-type fields excluding scaled_float. It can be disabled by setting the `index.mapping.use_doc_value_skipper` field to `false`
romseygeek
added
>non-issue
:StorageEngine/Mapping
Collaborator
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
martijnvg
approved these changes
Nov 24, 2025
|
|
||
| @Override | ||
| protected boolean supportsDocValuesSkippers() { | ||
| return false; |
Member
There was a problem hiding this comment.
Out of curiosity, why are skippers disabled for scaled_float when index=false and doc_values=true? Shouldn't this be similar to half_float?
Contributor
Author
There was a problem hiding this comment.
I think I just forgot to add them to scaled_float :). I will do that separately.
felixbarny
approved these changes
Nov 25, 2025
test/framework/src/main/java/org/elasticsearch/index/mapper/MapperTestCase.java
Outdated
Show resolved
Hide resolved
…pperTestCase.java Co-authored-by: Felix Barnsteiner <[email protected]>
Contributor
Author
|
This causes a failure in DataStreamTimestampFieldMapperTests#testValidatedNotIndexed, because we no longer fail validation if the timestamp field has index=false. I think that's probably OK, and I can just remove the test? |
…-false' into skippers/always-on-for-index-false
romseygeek
added
the
auto-merge-without-approval
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This applies to boolean, date, ip, keyword and number-type fields. It can
be disabled by setting the
index.mapping.use_doc_value_skipperfield tofalse