Skip to content

Remove feature flag to enable binary doc value compression #138524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
parkertimmins merged 6 commits into from
Nov 25, 2025
Merged

Remove feature flag to enable binary doc value compression #138524

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e1704d0
Remove binary dv compression feature flag
parkertimmins Nov 24, 2025
7cd4a72
Update docs/changelog/138524.yaml
parkertimmins Nov 24, 2025
9648b1d
[CI] Auto commit changes from spotless
Nov 24, 2025
5773361
Update docs/changelog/138524.yaml
parkertimmins Nov 25, 2025
3df0a67
update changelog
parkertimmins Nov 25, 2025
c8c305d
Merge branch 'main' into parker/remove-binary-dv-compression-feature-…
parkertimmins Nov 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions docs/changelog/138524.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
pr: 138524
summary: Remove feature flag to enable binary doc value compression
area: Mapping
type: feature
issues: []
5 changes: 1 addition & 4 deletions server/src/main/java/org/elasticsearch/index/codec/tsdb/es819/ES819TSDBDocValuesFormat.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@
import org.apache.lucene.codecs.DocValuesProducer;
import org.apache.lucene.index.SegmentReadState;
import org.apache.lucene.index.SegmentWriteState;
import org.elasticsearch.common.util.FeatureFlag;
import org.elasticsearch.core.SuppressForbidden;
import org.elasticsearch.index.codec.tsdb.BinaryDVCompressionMode;

Expand All @@ -37,8 +36,6 @@
*/
public class ES819TSDBDocValuesFormat extends org.apache.lucene.codecs.DocValuesFormat {

public static final boolean BINARY_DV_COMPRESSION_FEATURE_FLAG = new FeatureFlag("binary_dv_compression").isEnabled();

static final int NUMERIC_BLOCK_SHIFT = 7;
public static final int NUMERIC_BLOCK_SIZE = 1 << NUMERIC_BLOCK_SHIFT;
static final int NUMERIC_BLOCK_MASK = NUMERIC_BLOCK_SIZE - 1;
Expand Down Expand Up @@ -145,7 +142,7 @@ public ES819TSDBDocValuesFormat() {
DEFAULT_SKIP_INDEX_INTERVAL_SIZE,
ORDINAL_RANGE_ENCODING_MIN_DOC_PER_ORDINAL,
OPTIMIZED_MERGE_ENABLE_DEFAULT,
BINARY_DV_COMPRESSION_FEATURE_FLAG ? BinaryDVCompressionMode.COMPRESSED_ZSTD_LEVEL_1 : BinaryDVCompressionMode.NO_COMPRESS,
BinaryDVCompressionMode.COMPRESSED_ZSTD_LEVEL_1,
true
);
}
Expand Down
8 changes: 2 additions & 6 deletions ...src/test/java/org/elasticsearch/index/codec/tsdb/es819/ES819TSDBDocValuesFormatTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,13 +121,9 @@ protected Codec getCodec() {
return codec;
}

public void testBinaryCompressionFeatureFlag() {
public void testBinaryCompressionEnabled() {
ES819TSDBDocValuesFormat docValueFormat = new ES819TSDBDocValuesFormat();
if (ES819TSDBDocValuesFormat.BINARY_DV_COMPRESSION_FEATURE_FLAG) {
assertThat(docValueFormat.binaryDVCompressionMode, equalTo(BinaryDVCompressionMode.COMPRESSED_ZSTD_LEVEL_1));
} else {
assertThat(docValueFormat.binaryDVCompressionMode, equalTo(BinaryDVCompressionMode.NO_COMPRESS));
}
assertThat(docValueFormat.binaryDVCompressionMode, equalTo(BinaryDVCompressionMode.COMPRESSED_ZSTD_LEVEL_1));
}

public void testBlockWiseBinary() throws Exception {
Expand Down
3 changes: 1 addition & 2 deletions test/test-clusters/src/main/java/org/elasticsearch/test/cluster/FeatureFlag.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,7 @@ public enum FeatureFlag {
),
RANDOM_SAMPLING("es.random_sampling_feature_flag_enabled=true", Version.fromString("9.2.0"), null),
INFERENCE_API_CCM("es.inference_api_ccm_feature_flag_enabled=true", Version.fromString("9.3.0"), null),
GENERIC_VECTOR_FORMAT("es.generic_vector_format_feature_flag_enabled=true", Version.fromString("9.3.0"), null),
BINARY_DOC_VALUE_COMPRESSION("es.binary_dv_compression_feature_flag_enabled=true", Version.fromString("9.3.0"), null);
GENERIC_VECTOR_FORMAT("es.generic_vector_format_feature_flag_enabled=true", Version.fromString("9.3.0"), null);

public final String systemProperty;
public final Version from;
Expand Down
1 change: 0 additions & 1 deletion ...plugin/logsdb/src/yamlRestTest/java/org/elasticsearch/xpack/logsdb/LogsdbTestSuiteIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@ public class LogsdbTestSuiteIT extends ESClientYamlSuiteTestCase {
.setting("xpack.security.autoconfiguration.enabled", "false")
.setting("xpack.license.self_generated.type", "trial")
.feature(FeatureFlag.DOC_VALUES_SKIPPER)
.feature(FeatureFlag.BINARY_DOC_VALUE_COMPRESSION)
.build();

public LogsdbTestSuiteIT(@Name("yaml") ClientYamlTestCandidate testCandidate) {
Expand Down