Downsample exponential histograms #138561
Open
+485
−72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmarouli
added
>non-issue
:StorageEngine/Downsampling
Collaborator
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
JonasKunz
approved these changes
Nov 26, 2025
| * Creates a new instance with the OpenTelemetry SDK default bucket limit of {@link ExponentialHistogramMerger#MAX_HISTOGRAM_BUCKETS} | ||
| * @param circuitBreaker the circuit breaker to use to limit memory allocations | ||
| */ | ||
| public static ExponentialHistogramMerger create(ExponentialHistogramCircuitBreaker circuitBreaker) { |
Contributor
There was a problem hiding this comment.
Great idea to encode this default here!
I'll take care in a follow up to also use this in the ES|QL code.
...rc/main/java/org/elasticsearch/xpack/downsample/ExponentialHistogramMetricFieldProducer.java
Outdated
Show resolved
Hide resolved
…/downsample/ExponentialHistogramMetricFieldProducer.java Co-authored-by: Jonas Kunz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements downsampling for exponential histograms both as labels and as metrics. Marked as a non-issue because exponential histograms are behind a feature flag.
Closes #136259