Add seperate interface for UIAM authentication #138635
Merged
+117
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR separate allowCrossProject from IndicesRequest.Replaceable into its own interface so that it can be implemented by requests that are not replaceable, such as ES|QL query request. Relates: ES-13662
ywangd
added
>non-issue
:Security/Security
Collaborator
|
Pinging @elastic/es-security (Team:Security) |
elasticsearchmachine
added
Team:Security
ywangd
commented
Nov 26, 2025
Comment on lines
+564
to
565
| // If more exceptions are found, we can add a comment to above linked issue and relax this check further | ||
| assert replaceable.indices() == null || isNoneExpression(replaceable.indices()) : message; |
Member
Author
There was a problem hiding this comment.
Slobodan ran into this assertion failure. But I haven't seen it so far. This is a known issue. So I added a comment to say that we can relax it if it is triggered.
Contributor
There was a problem hiding this comment.
I run into this while running a newly added CPS ES|QL test.
ywangd
added
the
auto-merge-without-approval
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR separate allowCrossProject from IndicesRequest.Replaceable into its own interface so that it can be implemented by requests that are not replaceable, such as ES|QL query request.
Relates: ES-13662
Co-authored-by: Slobodan Adamović [email protected]