Support multiget actions during split #141560
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tim-Brooks
added
>non-issue
:Distributed/CRUD
Collaborator
|
Pinging @elastic/es-distributed (Team:Distributed) |
bcully
reviewed
Jan 30, 2026
Contributor
bcully
left a comment
bcully
left a comment
There was a problem hiding this comment.
Looks good - had a couple of questions, nothing major. Will there be a corresponding end-to-end test for this?
server/src/main/java/org/elasticsearch/action/get/MultiGetShardRequest.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/action/get/MultiGetShardSplitHelper.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/action/get/MultiGetShardSplitHelper.java
Outdated
Show resolved
Hide resolved
elasticsearchmachine
added
the
serverless-linked
Contributor
Author
|
I updated this to go the more basic reject strategy. |
ankikuma
reviewed
Feb 5, 2026
server/src/main/java/org/elasticsearch/index/get/ShardGetService.java
Outdated
Show resolved
Hide resolved
Contributor
|
Do we need a test for multiget with resharding ? |
mamazzol
pushed a commit
to mamazzol/elasticsearch
that referenced
this pull request
Feb 6, 2026
This commit ensures that multiget is properly delegated to new target shards in the middle of a split.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit ensures that multiget is properly delegated to new target
shards in the middle of a split.