Suppress mapper-parsing exception INFO logging #141590
Open
+17
−128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exceptions while parsing documents are returned to the client, which makes sense because the client has the most information about the context of the request and is best-placed to deal with the issue. Today we also log some of these exceptions in the server logs at `INFO` but this makes much less sense. Worse, these exceptions sometimes report fields from the document which might even include PII, and we shouldn't be recording PII in the server logs by default. This commit removes the unwanted `INFO`-level logging.
DaveCTurner
added
>bug
:Distributed/CRUD
elasticsearchmachine
added
Team:Distributed
Collaborator
|
Pinging @elastic/es-distributed (Team:Distributed) |
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exceptions while parsing documents are returned to the client, which
makes sense because the client has the most information about the
context of the request and is best-placed to deal with the issue. Today
we also log some of these exceptions in the server logs at
INFObutthis makes much less sense. Worse, these exceptions sometimes report
fields from the document which might even include PII, and we shouldn't
be recording PII in the server logs by default.
This commit removes the unwanted
INFO-level logging.