Skip to content

Change *OverTimeTests to extend AbstractAggregationTestCase#142659

Merged
kkrik-es merged 2 commits intoelastic:mainfrom
kkrik-es:tsdb/time-series-aggs-test-case
Feb 19, 2026
Merged

Change *OverTimeTests to extend AbstractAggregationTestCase#142659
kkrik-es merged 2 commits intoelastic:mainfrom
kkrik-es:tsdb/time-series-aggs-test-case

Conversation

@kkrik-es
Copy link
Contributor

This unlocks proper unittest coverage. Tests for data types using surrogates (amd, histograms), indicated that these classes should also implement SurrogateExpression.

Fixes #142558

@kkrik-es kkrik-es self-assigned this Feb 18, 2026
@kkrik-es kkrik-es added >test Issues or PRs that are addressing/adding tests Team:StorageEngine :StorageEngine/ES|QL Timeseries / metrics / PromQL / logsdb capabilities in ES|QL labels Feb 18, 2026
@kkrik-es kkrik-es requested a review from dnhatn February 18, 2026 19:36
@kkrik-es kkrik-es marked this pull request as ready for review February 18, 2026 19:36
@kkrik-es kkrik-es changed the title Change *OverTimeTests to inherit from AbstractAggregationTestCase Change *OverTimeTests to extend AbstractAggregationTestCase Feb 18, 2026
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-storage-engine (Team:StorageEngine)

Copy link
Member

@dnhatn dnhatn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks Kostas!

@kkrik-es kkrik-es merged commit 3c0342a into elastic:main Feb 19, 2026
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:StorageEngine/ES|QL Timeseries / metrics / PromQL / logsdb capabilities in ES|QL Team:StorageEngine >test Issues or PRs that are addressing/adding tests v9.4.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ESQL: Agg over time function tests not inheriting from AbstractAggregationTestCase

3 participants

Comments