Revert "[ESQL] Introduce pluggable external datasource framework (#141678)#142663
Merged
smalyshev merged 2 commits intoelastic:mainfrom Feb 19, 2026
Merged
Conversation
…stic#141678)" This reverts commit 6acdb30. It's causing HeapAttackIT to fail in serverless. On some machines. But not others! How exciting. For now, we'll revert and then try and get it back more slowly.
9e80fce to
b0b4b0f
Compare
Collaborator
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
Contributor
Author
|
@elasticsearchmachine test this please |
nik9000
approved these changes
Feb 18, 2026
eyalkoren
reviewed
Feb 19, 2026
| @@ -59,12 +59,13 @@ setup: | |||
| - cosine_vector_similarity_function | |||
| - inline_stats | |||
| - promql_command_v0 | |||
| - uri_parts_command | |||
Contributor
There was a problem hiding this comment.
@smalyshev why is this added here and the counter decreased?
I am adding a now command (and capability) now and I am uncertain as to what is expected
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 6acdb30. It's causing HeapAttackIT to fail in serverless. On some machines. But not others! How exciting.
For now, we'll revert and then try and get it back more slowly.
For context: this fails for me reliably on serverless main:
Fails with different seeds too. Does not fail with this revert.