Move tsdb doc values format larger numeric block variant to its own doc values format#142789
Draft
martijnvg wants to merge 2 commits intoelastic:mainfrom
Draft
Move tsdb doc values format larger numeric block variant to its own doc values format#142789martijnvg wants to merge 2 commits intoelastic:mainfrom
martijnvg wants to merge 2 commits intoelastic:mainfrom
Conversation
…oc values format This to make sure the larger numeric block size is always used when in time series mode. Previously, if the codec was constructed via SPI then we would still use the smaller numeric block size.
Member
Author
|
Buildkite benchmark this with tsdb-metricsgen-270m please |
Collaborator
💚 Build Succeeded
This build ran two tsdb-metricsgen-270m benchmarks to evaluate performance impact of this PR. History |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This to make sure the larger numeric block size is always used when in time series mode. Previously, if the codec was constructed via SPI then we would still use the smaller numeric block size.