add dlm force merge step skeleton#142791
Open
seanzatzdev wants to merge 4 commits intoelastic:mainfrom
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds a skeleton implementation for a DLM (Data Lifecycle Management) force merge step, which will be responsible for force merging indices as part of the data stream lifecycle management process. The implementation follows the DlmStep interface pattern established by ReadOnlyStep.
Changes:
- Added ForceMergeStep class implementing DlmStep interface with helper methods for checking and marking force merge completion
- Added comprehensive unit tests for the helper methods (stepCompleted, markForceMergeComplete, and stepName)
- Introduced a new index setting "index.lifecycle.dlm_force_merge_complete" to track force merge completion status
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| ForceMergeStep.java | Skeleton implementation of force merge step with completion checking and marking helpers; execute() method is stubbed with TODO |
| ForceMergeStepTests.java | Unit tests for stepCompleted, markForceMergeComplete, and stepName methods |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
.../src/main/java/org/elasticsearch/datastreams/lifecycle/transitions/steps/ForceMergeStep.java
Show resolved
Hide resolved
.../src/main/java/org/elasticsearch/datastreams/lifecycle/transitions/steps/ForceMergeStep.java
Outdated
Show resolved
Hide resolved
...test/java/org/elasticsearch/datastreams/lifecycle/transitions/steps/ForceMergeStepTests.java
Show resolved
Hide resolved
.../src/main/java/org/elasticsearch/datastreams/lifecycle/transitions/steps/ForceMergeStep.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
elasticsearchmachine
added
the
needs:triage
seanzatzdev
added
>non-issue
:StorageEngine/Data streams
Collaborator
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a skeleton and a few helpers for the dlm force merge step