ESIQL Improve LOOKUP JOIN on single keyword#143875
Closed
cimequinox wants to merge 11 commits intoelastic:mainfrom
Closed
ESIQL Improve LOOKUP JOIN on single keyword#143875cimequinox wants to merge 11 commits intoelastic:mainfrom
cimequinox wants to merge 11 commits intoelastic:mainfrom
Conversation
(cherry picked from commit 9b73572) # Conflicts: # x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/enrich/ExpressionQueryList.java
(cherry picked from commit 75d4a75)
(cherry picked from commit 118fbec)
ExpressionQueryList
* applyAsFastKeywordFilter
- only applies optimization for KEYWORD fields
- accepts context and follows pattern used by
applyAsLeftRightBinaryComparison to lookup dataType and
channelOffset before passing to BulkKeywordQueryList constructor.
* getPageCount passes inputPage when delegating to bulkKeywordQueryList
EnrichQuerySourceOperator
* inputPage passed to bulkQueryList methods
BulkKeywordQueryList
* holds channelOffset
* processQuery and getPositionCount take inputPage and
look up block using channelOffset
The class is really a specialized helper for the EnrichQuerySourceOperator (and eventually EnrichQueryFromExchangeOperator). It doesn't inherit or extend QueryList or implement the QueryList apis such as doGetQuery.
Also produce warning when encountering multivalues on left
Add evaluator to filter out false-positive multivalue matches Also generates warning when multivalues are encountered
Add near-duplicate row with multivalues for testing
Contributor
Author
|
Closing this as it predates Julian's recent lookup join work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.