Merged
Conversation
Closed
elasticsearchmachine
added
v9.4.0
needs:triage
Merged
sidosera
added
>non-issue
Team:StorageEngine
:StorageEngine/ES|QL
elasticsearchmachine
removed
the
needs:triage
Collaborator
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
sidosera
changed the title
sidosera
force-pushed
the
feature/esql-bucket-offset
branch
5 times, most recently
from
b52ba26 to
48cd9db
Compare
kkrik-es
reviewed
Mar 24, 2026
Contributor
kkrik-es
left a comment
kkrik-es
left a comment
There was a problem hiding this comment.
Looks reasonable to me.
dnhatn
approved these changes
Mar 24, 2026
sidosera
force-pushed
the
feature/esql-bucket-offset
branch
from
a190f7f to
558b7c0
Compare
eranweiss-elastic
pushed a commit
to eranweiss-elastic/elasticsearch
that referenced
this pull request
Mar 25, 2026
seanzatzdev
pushed a commit
to seanzatzdev/elasticsearch
that referenced
this pull request
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
offsetparameter toBUCKETfor step-aligned (i.e. non-truncated) time grouping.This is the foundation for TSTEP bucketing where buckets count backwards from the end of a time range rather than truncating to calendar boundaries.
Stack:
Depends on #143507