[PromQL] PromQL Translator Refactor#144953
Open
sidosera wants to merge 3 commits intoelastic:mainfrom
Open
Conversation
sidosera
force-pushed
the
feature/promql-without-cleanup
branch
from
6c9c6e0 to
b64f3ff
Compare
This was referenced Mar 25, 2026
sidosera
changed the title
sidosera
force-pushed
the
feature/promql-without-cleanup
branch
2 times, most recently
from
1d39414 to
0555b22
Compare
Collaborator
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
…timize label handling
sidosera
force-pushed
the
feature/promql-without-cleanup
branch
from
0555b22 to
dcdebaf
Compare
felixbarny
approved these changes
Mar 26, 2026
| // Self-resolution: at the innermost level there is no child aggregation to resolve against. | ||
| // This just splits declared labels into keys (_timeseries) vs attributes (concrete labels). | ||
| // var spec = labels.apply(labels); | ||
| // List<Attribute> all = new ArrayList<>(labels.excluded()); |
Member
There was a problem hiding this comment.
There's some commented out code here and a bit below.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This diff is primarily a clean-up from #144261. In introduces
LabelSetabstraction to encapsulate aggregate's label (groupings + aggregates) manipulation operations.Stack: