Introduce RefCountingRunnable #92620
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Today a `CountDownActionListener` which wraps a bare `Runnable` collects all the exceptions it receives only to drop them when finally completing the delegate action. Moreover callers must declare up-front the number of times the listener will be completed, which means they must put extra effort into computing this number ahead of time and/or supply an overestimate and then make up the difference with additional artificial completions. This commit introduces `RefCountingRunnable` which allows callers to acquire and release references as needed, executing the delegate `Runnable` once all references are released. It also refactors all the relevant call sites to use this new utility.
DaveCTurner
added
:Core/Infra/Core
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
|
There's a few things I want to use this for in follow-up work (notably #92607 and #92373) so if you think any of the usages in this PR are questionable then I'd rather back things out to merge this sooner instead of spending too much time iterating on this PR. (ofc if you think the whole concept is questionable then that's worth discussing here 😁) |
thecoop
reviewed
Jan 5, 2023
server/src/main/java/org/elasticsearch/action/support/RefCountingRunnable.java
Show resolved
Hide resolved
thecoop
reviewed
Jan 5, 2023
server/src/main/java/org/elasticsearch/action/support/RefCountingRunnable.java
Show resolved
Hide resolved
|
It's a good idea, but I'm concerned about the syntax here. I think it's hiding too much behind I think it needs to be more explicit in what it's doing in the code, and not use |
|
@elasticmachine please run elasticsearch-ci/part-2 |
|
Thanks Simon! |
DaveCTurner
added
the
auto-merge-without-approval
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Jan 10, 2023
Similar to the `RefCountingRunnable` introduced in elastic#92620, this commit introduces `RefCountingListener` which wraps an `ActionListener<Void>` and allows callers to acquire a dynamic collection of subsidiary listeners. The `RefCountingListener` counts responses and collects exceptions passed to these subsidiary listeners, and completes the wrapped listener once all acquired listeners are complete. Unlike a `CountDownActionListener` or a `GroupedActionListener`, this mechanism avoids the need for callers to declare up-front the number of times the listener will be completed, saving effort in computing this number ahead of time and avoiding the need to sometimes supply an overestimate and then make up the difference with additional artificial completions.
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Jan 17, 2023
Recent improvements to the primitives for writing async code (particularly elastic#92452 and elastic#92620) mean that we can enormously simplify `TransportNodesAction`. In particular, we can avoid accumulating an intermediate array of responses for later processing in favour of just accumulating the successes and failures into their final separate lists. We also no longer need to use a separate `NodesResponseTracker` to discard responses on cancellation.
DaveCTurner
added a commit
that referenced
this pull request
Jan 19, 2023
Recent improvements to the primitives for writing async code (particularly #92452 and #92620) mean that we can enormously simplify `TransportNodesAction`. In particular, we can avoid accumulating an intermediate array of responses for later processing in favour of just accumulating the successes and failures into their final separate lists. We also no longer need to use a separate `NodesResponseTracker` to discard responses on cancellation.
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Feb 2, 2023
Similarly to elastic#92987, recent improvements to the primitives for writing async code (particularly elastic#92452 and elastic#92620) mean that we can enormously simplify `TransportBroadcastByNodeAction`. In particular, we can avoid accumulating an intermediate array of responses for later processing in favour of just accumulating the successes and failures into their final separate lists. We also no longer need to use a separate `NodesResponseTracker` to discard responses on cancellation. Finally, we can now discard shard-level responses more promptly on cancellation.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 7, 2023
Similarly to #92987, recent improvements to the primitives for writing async code (particularly #92452 and #92620) mean that we can enormously simplify `TransportBroadcastByNodeAction`. In particular, we can avoid accumulating an intermediate array of responses for later processing in favour of just accumulating the successes and failures into their final separate lists. We also no longer need to use a separate `NodesResponseTracker` to discard responses on cancellation. Finally, we can now discard shard-level responses more promptly on cancellation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today a
CountDownActionListenerwhich wraps a bareRunnablecollects all the exceptions it receives only to drop them when finally completing the delegate action. Moreover callers must declare up-front the number of times the listener will be completed, which means they must put extra effort into computing this number ahead of time and/or supply an overestimate and then make up the difference with additional artificial completions.This commit introduces
RefCountingRunnablewhich allows callers to acquire and release references as needed, executing the delegateRunnableonce all references are released. It also refactors all the relevant call sites to use this new utility.