Generalize repo analysis #93899
Merged
Generalize repo analysis #93899
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In elastic#93825 we introduced a CAS operation on snapshot repositories. In due course we'll want to verify that this operation works as expected using the repository analysis API. This commit reworks the implementation slightly so as to simplify the change which will add this functionality.
DaveCTurner
added
:Distributed Coordination/Snapshot/Restore
elasticsearchmachine
added
the
Team:Distributed (Obsolete)
|
Pinging @elastic/es-distributed (Team:Distributed) |
DaveCTurner
commented
Feb 20, 2023
| import java.util.concurrent.Semaphore; | ||
| import java.util.function.BiConsumer; | ||
|
|
||
| public class ThrottledIterator<T> implements Releasable { |
There was a problem hiding this comment.
This class (and its test suite) extracted from #93735.
fcofdez
reviewed
Feb 20, 2023
| } | ||
| } | ||
|
|
||
| private final RefCounted throttleRefs; |
There was a problem hiding this comment.
nit: I find throttleRefs a bit confusing in this context, for what I understand this reference count does not control the throttling, it's used to notify the listener once all the tasks have finished, maybe we can find a clearer name?
There was a problem hiding this comment.
Sure, on reflection refs seems better to me.
fcofdez
approved these changes
Feb 20, 2023
DaveCTurner
added
the
auto-merge-without-approval
carlosdelest
pushed a commit
to carlosdelest/elasticsearch
that referenced
this pull request
Feb 21, 2023
In elastic#93825 we introduced a CAS operation on snapshot repositories. In due course we'll want to verify that this operation works as expected using the repository analysis API. This commit reworks the implementation slightly so as to simplify the change which will add this functionality.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #93825 we introduced a CAS operation on snapshot repositories. In due course we'll want to verify that this operation works as expected using the repository analysis API. This commit reworks the implementation slightly so as to simplify the change which will add this functionality.