Make list-tasks API cancellable #96283
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In a busy cluster the list-tasks API may retain information about a very large number of tasks while waiting for all nodes to respond. This commit makes the API cancellable so that unnecessary partial results can be released earlier. Relates elastic#96279, which implements the early-release functionality.
DaveCTurner
added
>non-issue
:Distributed Coordination/Task Management
elasticsearchmachine
added
the
Team:Distributed (Obsolete)
|
Pinging @elastic/es-distributed (Team:Distributed) |
arteam
reviewed
May 30, 2023
| tasksCancellable.cancel(); | ||
|
|
||
| final var taskManagers = new ArrayList<TaskManager>(internalCluster().getNodeNames().length); | ||
| for (final var transportService : internalCluster().getInstances(TransportService.class)) { |
There was a problem hiding this comment.
It's pity that internalCluster().getInstances returns Iterable, but it's actually a list. Otherwise, we could perform a check just with the Streams API.
internalCluster().getInstances(TransportService.class)
.stream()
.map(TransportService::getTaskManager)
.flatMap(taskManager -> taskManager.getCancellableTasks().values().stream())
.anyMatch(t -> t.getAction().startsWith(ListTasksAction.NAME));
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a busy cluster the list-tasks API may retain information about a very large number of tasks while waiting for all nodes to respond. This commit makes the API cancellable so that unnecessary partial results can be released earlier.
Relates #96279, which implements the early-release functionality.