Skip to content

Cleanup max retry decider #97440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Cleanup max retry decider #97440

wants to merge 1 commit into from

Conversation

@idegtiarenko
Copy link
Contributor

@idegtiarenko idegtiarenko commented Jul 7, 2023

This commit inlines method calls and replaces unnecessary debugDecision calls with allocation.decision ones

@idegtiarenko
Cleanup max retry decider
15257ce 
This commit inlines method calls and replaces unnecessary debugDecision calls
with `allocation.decision` ones
@idegtiarenko idegtiarenko added >non-issue :Distributed Coordination/Allocation All issues relating to the decision making around placing a shard (both master logic & on the nodes) Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. v8.9.1 labels Jul 7, 2023
@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Jul 7, 2023

Pinging @elastic/es-distributed (Team:Distributed)

original-brownbear
original-brownbear reviewed Jul 7, 2023
View reviewed changes
Copy link
Contributor

@original-brownbear original-brownbear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code was like this on purpose to make the decider compile to a much smaller method on the happy path. Not sure it's worth changing this even though it saves a couple of lines?

@volodk85 volodk85 added v8.9.2 and removed v8.9.1 labels Aug 11, 2023
@quux00 quux00 added v8.11.0 and removed v8.10.0 labels Aug 16, 2023
@mattc58 mattc58 added v8.12.0 and removed v8.11.0 labels Oct 4, 2023
@elasticsearchmachine elasticsearchmachine added v9.1.0 Team:Distributed Coordination Meta label for Distributed Coordination team and removed v9.0.0 labels Jan 30, 2025
@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Jan 30, 2025

Pinging @elastic/es-distributed-obsolete (Team:Distributed (Obsolete))

@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Jan 30, 2025

Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination)

@idegtiarenko idegtiarenko deleted the cleanup_myx_retry_decider branch April 22, 2025 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@original-brownbear original-brownbear original-brownbear left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

:Distributed Coordination/Allocation All issues relating to the decision making around placing a shard (both master logic & on the nodes) >non-issue Team:Distributed Coordination Meta label for Distributed Coordination team Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. v8.9.3 v9.1.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@idegtiarenko @elasticsearchmachine @original-brownbear @mattc58 @craigtaverner @quux00 @brianseeders @mark-vieira @volodk85