Skip to content

Cleanup max retry decider #97440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Cleanup max retry decider #97440

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
82 changes: 34 additions & 48 deletions .../java/org/elasticsearch/cluster/routing/allocation/decider/MaxRetryAllocationDecider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,8 @@

package org.elasticsearch.cluster.routing.allocation.decider;

import org.elasticsearch.cluster.routing.RelocationFailureInfo;
import org.elasticsearch.cluster.routing.RoutingNode;
import org.elasticsearch.cluster.routing.ShardRouting;
import org.elasticsearch.cluster.routing.UnassignedInfo;
import org.elasticsearch.cluster.routing.allocation.RoutingAllocation;
import org.elasticsearch.common.settings.Setting;

Expand Down Expand Up @@ -52,62 +50,50 @@ public Decision canAllocate(ShardRouting shardRouting, RoutingAllocation allocat
final var unassignedInfo = shardRouting.unassignedInfo();
final int numFailedAllocations = unassignedInfo == null ? 0 : unassignedInfo.getNumFailedAllocations();
if (numFailedAllocations > 0) {
final var decision = numFailedAllocations >= maxRetries ? Decision.NO : Decision.YES;
return allocation.debugDecision() ? debugDecision(decision, unassignedInfo, numFailedAllocations, maxRetries) : decision;
return numFailedAllocations >= maxRetries
? allocation.decision(
Decision.NO,
NAME,
"shard has exceeded the maximum number of retries [%d] on failed allocation attempts - "
+ "manually call [%s] to retry, [%s]",
maxRetries,
RETRY_FAILED_API,
unassignedInfo.toString()
)
: allocation.decision(
Decision.YES,
NAME,
"shard has failed allocating [%d] times but [%d] retries are allowed",
numFailedAllocations,
maxRetries
);
}

final var relocationFailureInfo = shardRouting.relocationFailureInfo();
final int numFailedRelocations = relocationFailureInfo == null ? 0 : relocationFailureInfo.failedRelocations();
if (numFailedRelocations > 0) {
final var decision = numFailedRelocations >= maxRetries ? Decision.NO : Decision.YES;
return allocation.debugDecision() ? debugDecision(decision, relocationFailureInfo, numFailedRelocations, maxRetries) : decision;
return numFailedRelocations >= maxRetries
? allocation.decision(
Decision.NO,
NAME,
"shard has exceeded the maximum number of retries [%d] on failed relocation attempts - "
+ "manually call [%s] to retry, [%s]",
maxRetries,
RETRY_FAILED_API,
relocationFailureInfo.toString()
)
: allocation.decision(
Decision.YES,
NAME,
"shard has failed relocating [%d] times but [%d] retries are allowed",
numFailedRelocations,
maxRetries
);
}

return YES_NO_FAILURES;
}

private static Decision debugDecision(Decision decision, UnassignedInfo info, int numFailedAllocations, int maxRetries) {
if (decision.type() == Decision.Type.NO) {
return Decision.single(
Decision.Type.NO,
NAME,
"shard has exceeded the maximum number of retries [%d] on failed allocation attempts - manually call [%s] to retry, [%s]",
maxRetries,
RETRY_FAILED_API,
info.toString()
);
} else {
return Decision.single(
Decision.Type.YES,
NAME,
"shard has failed allocating [%d] times but [%d] retries are allowed",
numFailedAllocations,
maxRetries
);
}
}

private static Decision debugDecision(Decision decision, RelocationFailureInfo info, int numFailedRelocations, int maxRetries) {
if (decision.type() == Decision.Type.NO) {
return Decision.single(
Decision.Type.NO,
NAME,
"shard has exceeded the maximum number of retries [%d] on failed relocation attempts - manually call [%s] to retry, [%s]",
maxRetries,
RETRY_FAILED_API,
info.toString()
);
} else {
return Decision.single(
Decision.Type.YES,
NAME,
"shard has failed relocating [%d] times but [%d] retries are allowed",
numFailedRelocations,
maxRetries
);
}
}

@Override
public Decision canAllocate(ShardRouting shardRouting, RoutingNode node, RoutingAllocation allocation) {
return canAllocate(shardRouting, allocation);
Expand Down