Makes lineal the calculation of IndicesQueryCache #97600
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
July 11, 2023 17:07
HiDAl
added
>bug
:Data Management/Stats
|
Hi @HiDAl, I've created a changelog YAML for you. |
added 2 commits
July 12, 2023 09:56
…, simplifying the code
|
Closing this due to staleness and a more recent PR being opened: #130857. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #97222, the calculation of
IndicesQueryCacheis computationally expensive due to some internal loops. Reading the current code, it'd be hard to simplify the calculation, without a big refactor. This is asad and hackyattempt to give a solution to the current situation (Draft PR 😉), so users won't be affected by thisO(n^2)loop.In strange case that this solution suffices in the short term, we can apply the same idea to the following classes, which are still using the old approach TransportClusterStatsAction.java & TransportClusterStatsAction.javaLast night, in a dream, I came up with hismemoizedsolution, which I applied to these 2 classes.closes #97222