Skip to content

[8.x](backport #4766) split FIPS unit tests from fips140=only test#4769

Merged
michel-laterman merged 1 commit into8.xfrom
mergify/bp/8.x/pr-4766
Apr 9, 2025
Merged

[8.x](backport #4766) split FIPS unit tests from fips140=only test#4769
michel-laterman merged 1 commit into8.xfrom
mergify/bp/8.x/pr-4766

Conversation

@mergify
Copy link
Copy Markdown
Contributor

@mergify mergify bot commented Apr 4, 2025

What is the problem this PR solves?

Split the single "Run FIPS unit tests" in the buildkite pipeline into two steps,

  • "Run FIPS unit tests" - runs unit tests with -tags=requirefips
  • "Run fips140=only unit tests" - runs unit tests with -tags=requirefips and GODEBUG=fips140=only

This way it is easier to determine what causes a failure with FIPS functionality.

This also makes fleet-server consistent with the testing approach being implemented in elastic-agent and elastic-agent-libs.


This is an automatic backport of pull request #4766 done by Mergify.

split FIPS unit tests from fips140=only test

(cherry picked from commit 9f65d34)
@mergify mergify bot added the backport label Apr 4, 2025
@mergify mergify bot requested a review from a team as a code owner April 4, 2025 20:57
@mergify mergify bot requested review from andrzej-stencel and kaanyalti April 4, 2025 20:57
@github-actions github-actions bot added Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team tech debt labels Apr 4, 2025
@elastic-sonarqube
Copy link
Copy Markdown

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@mergify
Copy link
Copy Markdown
Contributor Author

mergify bot commented Apr 7, 2025

This pull request has not been merged yet. Could you please review and merge it @michel-laterman? 🙏

@michel-laterman michel-laterman merged commit 69455d3 into 8.x Apr 9, 2025
10 checks passed
@michel-laterman michel-laterman deleted the mergify/bp/8.x/pr-4766 branch April 9, 2025 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team tech debt

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant