[8.x](backport #4762) Clear upgrade_attempts on handleAck #4778
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* clear upgrade_attempts on handleAck * clear upgrade_attempts if upgrade_details is missing * added unit test (cherry picked from commit fb093cc)
github-actions
bot
added
enhancement
* Clear agent.upgrade_attemps on upgrade complete * This actually works * Silence nolintlint error in handleCheckin.go * Remove nolint comment altogether * Add changelog * Update handleCheckin unit test * Change approach * Revert unit test change * This seems needed * Run make generate * Remove internal link * add unit test * reduce complexity * return nil if action is nil --------- Co-authored-by: Julia Bardi <[email protected]> Co-authored-by: Julia Bardi <[email protected]> (cherry picked from commit 2b40416) Co-authored-by: Jill Guyonnet <[email protected]>
|
Contributor
|
@michalpristas Hey, could you review this backport? |
michalpristas
approved these changes
Apr 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the problem this PR solves?
upgrade_attemptswere not cleared correctly when agent doesn't haveupgrade_details(for example in horde or older versions).How does this PR solve the problem?
Clear
upgrade_attemptswhen upgrade is acked (at the same time whenupgrade_started_atfield is cleared).How to test this PR locally
Test with agent policy with auto upgrade config and a few horde agents enrolled. Verify that after the upgrade completed,
upgrade_attemptsis set tonull.The
upgrade_attemptsfield is only cleared if there is noupgrade_details. Tested with a real agent upgraded to a non-existent version, the agent going toUPG_FAILEDstate.Design Checklist
Checklist
./changelog/fragmentsusing the changelog toolRelated issues
Relates #4528
Relates elastic/kibana#212744
This is an automatic backport of pull request #4762 done by [Mergify](https://mergify.com).
Rebased #4777 as this pr depends on it.