Skip to content

feat: bump uuid lib to v5#4829

Merged
kruskall merged 10 commits intoelastic:mainfrom
kruskall:feat/bump-uuid-v5
May 23, 2025
Merged

feat: bump uuid lib to v5#4829
kruskall merged 10 commits intoelastic:mainfrom
kruskall:feat/bump-uuid-v5

Conversation

@kruskall
Copy link
Copy Markdown
Member

What is the problem this PR solves?

fleet server is shipping two major versions of the same lib

How does this PR solve the problem?

update uuid to v5 and use it consistently

How to test this PR locally

Design Checklist

  • I have ensured my design is stateless and will work when multiple fleet-server instances are behind a load balancer.
  • I have or intend to scale test my changes, ensuring it will work reliably with 100K+ agents connected.
  • I have included fail safe mechanisms to limit the load on fleet-server: rate limiting, circuit breakers, caching, load shedding, etc.

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool

Related issues

fleet server is shipping two major versions of the same lib

update uuid to v5 and use it consistently
@kruskall kruskall requested a review from a team as a code owner April 18, 2025 14:20
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Apr 18, 2025

This pull request does not have a backport label. Could you fix it @kruskall? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-./d./d is the label to automatically backport to the 8./d branch. /d is the digit
  • backport-active-all is the label that automatically backports to all active branches.
  • backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
  • backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.

@pierrehilbert pierrehilbert added the Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team label Apr 22, 2025
@michel-laterman
Copy link
Copy Markdown
Contributor

There's an issue with the integration tests:

panic: test timed out after 10m0s
  | running tests:
  | TestServerInstrumentation (9m21s)
  |  
  | goroutine 2134 [running]:
  | testing.(*M).startAlarm.func1()
  | /opt/buildkite-agent/.gvm/versions/go1.24.2.linux.amd64/src/testing/testing.go:2484 +0x605
  | created by time.goFunc
  | /opt/buildkite-agent/.gvm/versions/go1.24.2.linux.amd64/src/time/sleep.go:215 +0x45
  |  
  | goroutine 1 [chan receive, 9 minutes]:
  | testing.(*T).Run(0xc000182a80, {0x233dbd8, 0x19}, 0x2381960)
  | /opt/buildkite-agent/.gvm/versions/go1.24.2.linux.amd64/src/testing/testing.go:1859 +0x91e
  | testing.runTests.func1(0xc000182a80)
  | /opt/buildkite-agent/.gvm/versions/go1.24.2.linux.amd64/src/testing/testing.go:2279 +0x86
  | testing.tRunner(0xc000182a80, 0xc00061fae0)
  | /opt/buildkite-agent/.gvm/versions/go1.24.2.linux.amd64/src/testing/testing.go:1792 +0x226
  | testing.runTests(0xc0000111e8, {0x32f36a0, 0x1c, 0x1c}, {0x1?, 0x0?, 0x3365a60?})
  | /opt/buildkite-agent/.gvm/versions/go1.24.2.linux.amd64/src/testing/testing.go:2277 +0x96d
  | testing.(*M).Run(0xc000351e00)
  | /opt/buildkite-agent/.gvm/versions/go1.24.2.linux.amd64/src/testing/testing.go:2142 +0xeeb
  | main.main()
  | _testmain.go:99 +0x165
  |  
...

@pkoutsovasilis pkoutsovasilis dismissed michel-laterman’s stale review May 1, 2025 00:13

let's wait for the unit-test to be green and then re-approve

@kruskall
Copy link
Copy Markdown
Member Author

kruskall commented May 1, 2025

There's an issue with the integration tests:

should be fixed! Thanks for sharing the logs! 🙇

Copy link
Copy Markdown
Contributor

@pkoutsovasilis pkoutsovasilis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kruskall could you please have a look at the linter errors 🙂

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented May 7, 2025

This pull request is now in conflicts. Could you fix it @kruskall? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b feat/bump-uuid-v5 upstream/feat/bump-uuid-v5
git merge upstream/main
git push upstream feat/bump-uuid-v5

@prodsecmachine
Copy link
Copy Markdown

prodsecmachine commented May 18, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

license/snyk check is complete. No issues have been found. (View Details)

@elastic-sonarqube
Copy link
Copy Markdown

@kruskall
Copy link
Copy Markdown
Member Author

@kruskall could you please have a look at the linter errors 🙂

fixed 👍

Copy link
Copy Markdown
Contributor

@pkoutsovasilis pkoutsovasilis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thx for handling this @kruskall

@kruskall kruskall merged commit c25bcf3 into elastic:main May 23, 2025
9 checks passed
@kruskall kruskall deleted the feat/bump-uuid-v5 branch May 24, 2025 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants