Skip to content

fix: also commit NOTICE-FIPS.txt changes from dependabot#5015

Merged
pkoutsovasilis merged 1 commit intoelastic:mainfrom
pkoutsovasilis:ci/fix_post_dependabot_notice_fips
Jun 6, 2025
Merged

fix: also commit NOTICE-FIPS.txt changes from dependabot#5015
pkoutsovasilis merged 1 commit intoelastic:mainfrom
pkoutsovasilis:ci/fix_post_dependabot_notice_fips

Conversation

@pkoutsovasilis
Copy link
Copy Markdown
Contributor

@pkoutsovasilis pkoutsovasilis commented Jun 6, 2025

What is the problem this PR solves?

Dependabot PRs for main and 8.19 are failing CI due to uncommitted changes in the NOTICE-FIPS.txt file. This file gets modified during dependency updates but was not included in the set of files automatically committed by the post-dependabot workflow, causing the workflow to detect dirty state and fail.

Some affected PRs: #5014, #5013, #5012

How does this PR solve the problem?

This PR updates the post-dependabot.yml GitHub Actions workflow to also track and commit changes to the NOTICE-FIPS.txt file, alongside NOTICE.txt, testing/go.mod, and testing/go.sum. This ensures all modified files are committed and CI passes successfully.

How to test this PR locally

Not entirely sure how someone can artificially trigger the dependabot flow 🙂

Design Checklist

  • I have ensured my design is stateless and will work when multiple fleet-server instances are behind a load balancer.
  • I have or intend to scale test my changes, ensuring it will work reliably with 100K+ agents connected.
  • I have included fail safe mechanisms to limit the load on fleet-server: rate limiting, circuit breakers, caching, load shedding, etc.

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool

Related issues

N/A

@pkoutsovasilis pkoutsovasilis added Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team backport-8.19 Automated backport to the 8.19 branch skip-changelog labels Jun 6, 2025
@pkoutsovasilis pkoutsovasilis self-assigned this Jun 6, 2025
@prodsecmachine
Copy link
Copy Markdown

prodsecmachine commented Jun 6, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

license/snyk check is complete. No issues have been found. (View Details)

@pkoutsovasilis pkoutsovasilis marked this pull request as ready for review June 6, 2025 06:56
@pkoutsovasilis pkoutsovasilis requested a review from a team as a code owner June 6, 2025 06:56
@pkoutsovasilis pkoutsovasilis merged commit c538e8e into elastic:main Jun 6, 2025
8 checks passed
mergify bot pushed a commit that referenced this pull request Jun 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-8.19 Automated backport to the 8.19 branch skip-changelog Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants