Skip to content

github(codeowners): robots-ci can review .github/workflows only#5112

Merged
v1v merged 1 commit intomainfrom
v1v-patch-1
Jul 9, 2025
Merged

github(codeowners): robots-ci can review .github/workflows only#5112
v1v merged 1 commit intomainfrom
v1v-patch-1

Conversation

@v1v
Copy link
Copy Markdown
Member

@v1v v1v commented Jul 8, 2025

What is the problem this PR solves?

// Please do not just reference an issue. Explain WHAT the problem this PR solves here.

How does this PR solve the problem?

This should help with letting the teams own other files under the .github folder

How to test this PR locally

Design Checklist

  • I have ensured my design is stateless and will work when multiple fleet-server instances are behind a load balancer.
  • I have or intend to scale test my changes, ensuring it will work reliably with 100K+ agents connected.
  • I have included fail safe mechanisms to limit the load on fleet-server: rate limiting, circuit breakers, caching, load shedding, etc.

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool

Related issues

@v1v v1v requested review from a team as code owners July 8, 2025 07:02
@prodsecmachine
Copy link
Copy Markdown

prodsecmachine commented Jul 8, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

license/snyk check is complete. No issues have been found. (View Details)

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jul 8, 2025

This pull request does not have a backport label. Could you fix it @v1v? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-./d./d is the label to automatically backport to the 8./d branch. /d is the digit
  • backport-active-all is the label that automatically backports to all active branches.
  • backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
  • backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.

@v1v v1v enabled auto-merge (squash) July 8, 2025 08:40
@v1v v1v self-assigned this Jul 8, 2025
@v1v v1v added the backport-8.19 Automated backport to the 8.19 branch label Jul 8, 2025
Copy link
Copy Markdown
Contributor

@fr4nc1sc0-r4m0n fr4nc1sc0-r4m0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@v1v v1v merged commit 34a1057 into main Jul 9, 2025
8 checks passed
@v1v v1v deleted the v1v-patch-1 branch July 9, 2025 09:06
mergify bot pushed a commit that referenced this pull request Jul 9, 2025
(cherry picked from commit 34a1057)

# Conflicts:
#	.github/CODEOWNERS
v1v pushed a commit that referenced this pull request Jul 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-8.19 Automated backport to the 8.19 branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants