Make action optional when upgrade details are provided #5609
Conversation
michalpristas
added
Team:Elastic-Agent-Control-Plane
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
michalpristas
changed the title
…-server into fix/migrate-watching
There was a problem hiding this comment.
Sorry I am having trouble following how this PR works.
Does this fix the issue where if you check-in to a new cluster for the first time after migrate that it will reflect the upgrade state of that agent? If so, could you walk me through how this is done in this code.
| action, err := ct.verifyActionExists(ctx, vSpan, agent, details) | ||
| if err != nil { | ||
|
|
||
| var actionTraceparent string |
There was a problem hiding this comment.
@blakerouse normally when no actin is present we stop here
but we make loading optional and if action is not present we just set traceparent (only property used here in the code) to ""
then later we check if we have here when setting parent span and continue until we reach a point where we update details on line 543
3 participants
In a context of agent migration.
When agent is migrated and still has some upgrade details or upgrade was triggered manually for some reason we should reflect that in UI.
This PR makes action optional and updates upgrade details anyways.
I'd like ACK handling of upgrade to be reworked, but ideally in a separate PR to lower risk as I'd like this one to be in 9.2
Fixes: #5564