Skip to content

[8.19](backport #5715) re-enable CGO and buildmode pie #5718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 8.19
Choose a base branch
from
+2 −2
Open

[8.19](backport #5715) re-enable CGO and buildmode pie #5718

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions magefile.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,7 @@ const (

// const and vars used by magefile.
const (
buildMode = "pie"
binaryName = "fleet-server"
binaryExe = "fleet-server.exe"

Expand Down Expand Up @@ -695,7 +696,6 @@ func (Check) All() {
// FIPS creates a FIPS capable binary.
func (Build) Local() error {
env := environMap()
env["CGO_ENABLED"] = "0"
if isFIPS() {
addFIPSEnvVars(env)
}
Expand Down Expand Up @@ -729,7 +729,6 @@ func goBuild(osArg, archArg string, cover bool) error {
env := environMap()
env["GOOS"] = osArg
env["GOARCH"] = archArg
env["CGO_ENABLED"] = "0"
distArr := []string{"fleet-server"}
if isFIPS() {
addFIPSEnvVars(env)
Expand All @@ -755,6 +754,7 @@ func goBuild(osArg, archArg string, cover bool) error {
"-tags=" + getTagsString(),
"-gcflags=" + getGCFlags(),
"-ldflags=" + getLDFlags(),
"-buildmode=" + buildMode,
"-o", outFile,
}
if cover {
Expand Down