-
Couldn't load subscription status.
- Fork 18
Introduce merge and split experimental APIs for bulk indexers #265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lahsivjar this is only going to be used by the otel elasticsearch exporter right? I wonder if we should expose some lower level functionality from go-docappender, and keep the split/merge logic in the exporter?
Maybe one option for that would be to introduce a new "BulkIndexerBuffer" type that contains the Add method. It could have a Split method, or it could perhaps just have a method for iterating over items in the buffer and we can leave it to the caller to copy those to a new buffer.
Good idea! I will look into it. |
The merge and split APIs will allow Elasticsearch exporter to size the requests to ES using the new batch queue based on the bulk request sizes.