Skip to content

Conversation

@lahsivjar
Copy link
Contributor

The merge and split APIs will allow Elasticsearch exporter to size the requests to ES using the new batch queue based on the bulk request sizes.

@lahsivjar lahsivjar requested a review from a team as a code owner August 21, 2025 09:29
@lahsivjar lahsivjar marked this pull request as draft August 21, 2025 09:30
@elastic-observability-automation elastic-observability-automation bot added the safe-to-test Automated label for running bench-diff on forked PRs label Aug 21, 2025
@lahsivjar lahsivjar changed the title Introduce merge and split experimental APIs for bulk indexers [WIP] Introduce merge and split experimental APIs for bulk indexers Aug 21, 2025
@lahsivjar lahsivjar changed the title [WIP] Introduce merge and split experimental APIs for bulk indexers Introduce merge and split experimental APIs for bulk indexers Oct 2, 2025
@lahsivjar lahsivjar marked this pull request as ready for review October 2, 2025 10:24
@lahsivjar lahsivjar requested review from a team and axw October 7, 2025 11:07
Copy link
Member

@axw axw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lahsivjar this is only going to be used by the otel elasticsearch exporter right? I wonder if we should expose some lower level functionality from go-docappender, and keep the split/merge logic in the exporter?

Maybe one option for that would be to introduce a new "BulkIndexerBuffer" type that contains the Add method. It could have a Split method, or it could perhaps just have a method for iterating over items in the buffer and we can leave it to the caller to copy those to a new buffer.

@lahsivjar
Copy link
Contributor Author

@lahsivjar this is only going to be used by the otel elasticsearch exporter right? I wonder if we should expose some lower level functionality from go-docappender, and keep the split/merge logic in the exporter?

Maybe one option for that would be to introduce a new "BulkIndexerBuffer" type that contains the Add method. It could have a Split method, or it could perhaps just have a method for iterating over items in the buffer and we can leave it to the caller to copy those to a new buffer.

Good idea! I will look into it.

@lahsivjar lahsivjar marked this pull request as draft October 20, 2025 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe-to-test Automated label for running bench-diff on forked PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants