Skip to content

Add queue size multiplier config to BulkIndexer #1029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −4
Open

Add queue size multiplier config to BulkIndexer #1029

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions esutil/bulk_indexer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,9 +54,10 @@ type BulkIndexer interface {

// BulkIndexerConfig represents configuration of the indexer.
type BulkIndexerConfig struct {
NumWorkers int // The number of workers. Defaults to runtime.NumCPU().
FlushBytes int // The flush threshold in bytes. Defaults to 5MB.
FlushInterval time.Duration // The flush threshold as duration. Defaults to 30sec.
NumWorkers int // The number of workers. Defaults to runtime.NumCPU().
FlushBytes int // The flush threshold in bytes. Defaults to 5MB.
FlushInterval time.Duration // The flush threshold as duration. Defaults to 30sec.
QueueSizeMultiplier int // The multiplier on the size of the worker queue. Defaults to 1.

Client esapi.Transport // The Elasticsearch client.
Decoder BulkResponseJSONDecoder // A custom JSON decoder.
Expand Down Expand Up @@ -301,6 +302,10 @@ func NewBulkIndexer(cfg BulkIndexerConfig) (BulkIndexer, error) {
cfg.FlushInterval = 30 * time.Second
}

if cfg.QueueSizeMultiplier == 0 {
cfg.QueueSizeMultiplier = 1
}

bi := bulkIndexer{
config: cfg,
stats: &bulkIndexerStats{},
Expand Down Expand Up @@ -371,7 +376,7 @@ func (bi *bulkIndexer) Stats() BulkIndexerStats {

// init initializes the bulk indexer.
func (bi *bulkIndexer) init() {
bi.queue = make(chan BulkIndexerItem, bi.config.NumWorkers)
bi.queue = make(chan BulkIndexerItem, bi.config.NumWorkers*bi.config.QueueSizeMultiplier)

for i := 1; i <= bi.config.NumWorkers; i++ {
bi.wg.Add(1)
Expand Down