Skip to content

Return error when default URL cannot be parsed #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Return error when default URL cannot be parsed #205

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f8b756a
check error on init
tty2 Dec 8, 2020
5bbbbff
Return error when default URL cannot be parsed
tty2 Dec 9, 2020
83712ca
remove redundant test case
tty2 Dec 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions elasticsearch.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,10 @@ func NewClient(cfg Config) (*Client, error) {
}

if len(urls) == 0 {
u, _ := url.Parse(defaultURL) // errcheck exclude
u, err := url.Parse(defaultURL)
if err != nil {
return nil, fmt.Errorf("cannot parse default URL: %v", err)
}
urls = append(urls, u)
}

Expand Down Expand Up @@ -220,7 +223,7 @@ func addrsToURLs(addrs []string) ([]*url.URL, error) {
for _, addr := range addrs {
u, err := url.Parse(strings.TrimRight(addr, "/"))
if err != nil {
return nil, fmt.Errorf("cannot parse url: %v", err)
return nil, fmt.Errorf("cannot parse URL: %v", err)
}

urls = append(urls, u)
Expand Down