Skip to content

Fix memory leak bulk indexer #701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix memory leak bulk indexer #701

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a53d36b
Fix memory leak bulk indexer
mhmtszr Jul 19, 2023
c445c2e
Fix wrong sync pool location
mhmtszr Jul 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion esutil/bulk_indexer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,6 +265,12 @@ type bulkIndexerStats struct {
numRequests uint64
}

var bufPool = &sync.Pool{
New: func() interface{} {
return new(bytes.Buffer)
},
}

// NewBulkIndexer creates a new bulk indexer.
func NewBulkIndexer(cfg BulkIndexerConfig) (BulkIndexer, error) {
if cfg.Client == nil {
Expand Down Expand Up @@ -337,6 +343,11 @@ func (bi *bulkIndexer) Close(ctx context.Context) error {
bi.wg.Wait()
}

for _, w := range bi.workers {
w.buf.Reset()
bufPool.Put(w.buf)
}

return nil
}

Expand All @@ -363,7 +374,7 @@ func (bi *bulkIndexer) init() {
id: i,
ch: bi.queue,
bi: bi,
buf: bytes.NewBuffer(make([]byte, 0, bi.config.FlushBytes)),
buf: bufPool.Get().(*bytes.Buffer),
ticker: time.NewTicker(bi.config.FlushInterval),
}
w.run()
Expand Down